Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Aug. 30, 2016, 8:37 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Aug. 30, 2016, 8:52 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147359 --- Ship it! Master (c99f2fb) is green with this patch. ./build-s

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147358 --- src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 9:25 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java, > > lines 191-201 > > > > > > Beyond setting things up to use the new style executor

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 11:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > line 143 > > > > > > We should add a constant to api.thrift for `health` and use it

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 9:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > line 143 > > > > > > We should add a constant to api.thrift for `health` and use it

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 9:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > line 130 > > > > > > Doing this based simply on the presence of a string feels britt

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 2:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > line 130 > > > > > > Doing this based simply on the presence of a string feels britt

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 9:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > line 143 > > > > > > We should add a constant to api.thrift for `health` and use it

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Aug. 31, 2016, 10:08 p.m.) Review request for Aurora, Joshua Cohen, Ma

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147498 --- Ship it! Master (bd11b1c) is green with this patch. ./build-s

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 9:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > line 130 > > > > > > Doing this based simply on the presence of a string feels britt

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147597 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 467) <

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147599 --- src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 1, 2016, 7:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > > > > > This is not sufficent to determine if healthchecking occurs. > > > > We now s

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 1, 2016, 7:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > > > > > This is not sufficent to determine if healthchecking occurs. > > > > We now s

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 1, 2016, 7:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > > > > > This is not sufficent to determine if healthchecking occurs. > > > > We now s

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 2, 2016, 3:55 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 1, 2016, 7:59 p.m., Dmitriy Shirchenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > lines 126-131 > > > > > > +1 on @zmanji's comment. > > https://github.com/apa

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 1, 2016, 7:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > > > > > This is not sufficent to determine if healthchecking occurs. > > > > We now s

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 1, 2016, 12:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > > > > > This is not sufficent to determine if healthchecking occurs. > > > > We now

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 7, 2016, 10:06 p.m.) Review request for Aurora, Joshua Cohen, Ma

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148100 --- Ship it! Master (19866b5) is green with this patch. ./build-s

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148102 --- RELEASE-NOTES.md (line 37)

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148103 --- Also can you please update the review title and commit message to