Re: Review Request 60376: Observer task page to load consumption info from history

> On July 18, 2017, 7:15 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/thermos/monitoring/resource.py > > Lines 101 (patched) > > > > > > s/ProcessStatus/process_status/ Done. - Reza

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180825 --- Ship it! Master (243d6fa) is green with this patch. ./build-s

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/ --- (Updated July 18, 2017, 4:14 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180798 --- Ship it! src/main/python/apache/thermos/monitoring/resource.py

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180795 --- Master (243d6fa) is red with this patch. ./build-support/jenkins

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/ --- (Updated July 18, 2017, 6:26 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 60376: Observer task page to load consumption info from history

> On July 18, 2017, 12:46 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/thermos/monitoring/resource.py > > Line 54 (original), 53-60 (patched) > > > > > > Can you add some docstrings to these class

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180775 --- LGTM. Some minor comments. src/main/python/apache/thermos/monito

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review179411 --- Ship it! Ship It! - Stephan Erb On June 29, 2017, 8:32 p.m.,

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review179297 --- Ship it! Master (a922b05) is green with this patch. ./build-s

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/ --- (Updated June 29, 2017, 6:32 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 60376: Observer task page to load consumption info from history

> On June 28, 2017, 7:15 p.m., Aurora ReviewBot wrote: > > Master (a922b05) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Downloading six-1.10.0-py2.py3-none-any.whl > > Collecting ansicolors==1.0.2 (from pantsbuild.pants==1.3.0.dev3) > > Downloading ansicolors-1.0.2

Re: Review Request 60376: Observer task page to load consumption info from history

> On June 27, 2017, 9:10 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/monitoring/resource.py > > Line 54 (original), 53 (patched) > > > > > > It might be worth to rename this to something like > > 'Agg

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review179153 --- Master (a922b05) is red with this patch. ./build-support/jenkins

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/ --- (Updated June 28, 2017, 7:01 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review179043 --- Let's see how this works out in practice! I am really looking forw

Re: Review Request 60376: Observer task page to load consumption info from history

> On June 26, 2017, 5:38 p.m., Stephan Erb wrote: > > What is your main optimization objective? Reducing page load time or > > reducing steady observer CPU load? > > > > I have observed that when running many tasks per node (say ~30-100), it can > > happen that the metric collection threads e

Re: Review Request 60376: Observer task page to load consumption info from history

> On June 26, 2017, 5:38 p.m., Stephan Erb wrote: > > What is your main optimization objective? Reducing page load time or > > reducing steady observer CPU load? > > > > I have observed that when running many tasks per node (say ~30-100), it can > > happen that the metric collection threads e

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review178907 --- What is your main optimization objective? Reducing page load time

Re: Review Request 60376: Observer task page to load consumption info from history

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review178736 --- Ship it! Master (a922b05) is green with this patch. ./build-s