Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review79785 --- Ship it! Master (084a622) is green with this patch. ./build-suppo

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review79784 --- Ship it! Ship It! - Kevin Sweeney On April 10, 2015, 4:42 p.m.,

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/ --- (Updated April 10, 2015, 11:42 p.m.) Review request for Aurora, Kevin Sweeney a

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Maxim Khutornenko
> On April 1, 2015, 8:40 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/BUILD, line 29 > > > > > > How about "kaurora" > > Maxim Khutornenko wrote: > This is a joke, right? :) If not I am r

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Maxim Khutornenko
> On April 10, 2015, 10:52 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, line 32 > > > > > > nit: trailing comma here Done. > On April 10, 2015, 10:52 p.m., Kevin Sweene

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review79770 --- Ship it! Master (084a622) is green with this patch. ./build-suppo

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Kevin Sweeney
> On April 1, 2015, 1:40 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/BUILD, line 29 > > > > > > How about "kaurora" > > Maxim Khutornenko wrote: > This is a joke, right? :) If not I am r

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review79766 --- src/main/python/apache/aurora/client/api/scheduler_client.py

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/ --- (Updated April 10, 2015, 10:45 p.m.) Review request for Aurora, Kevin Sweeney a

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review79765 --- This patch does not apply cleanly on master (084a622), do you need t

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/ --- (Updated April 10, 2015, 10:38 p.m.) Review request for Aurora, Kevin Sweeney a

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Maxim Khutornenko
> On April 1, 2015, 8:40 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/BUILD, line 29 > > > > > > How about "kaurora" > > Maxim Khutornenko wrote: > This is a joke, right? :) If not I am r

Re: Review Request 32541: Adding client Kerberos support.

2015-04-08 Thread Kevin Sweeney
> On April 1, 2015, 1:40 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/BUILD, line 29 > > > > > > How about "kaurora" > > Maxim Khutornenko wrote: > This is a joke, right? :) If not I am r

Re: Review Request 32541: Adding client Kerberos support.

2015-04-07 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review79200 --- Ship it! - Brian Wickman On April 2, 2015, 5:33 p.m., Maxim Khuto

Re: Review Request 32541: Adding client Kerberos support.

2015-04-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review78951 --- Ping Brian. - Maxim Khutornenko On April 2, 2015, 5:33 p.m., Maxi

Re: Review Request 32541: Adding client Kerberos support.

2015-04-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review78685 --- Master (4b9c759) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32541: Adding client Kerberos support.

2015-04-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/ --- (Updated April 2, 2015, 5:33 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 32541: Adding client Kerberos support.

2015-04-02 Thread Maxim Khutornenko
> On April 1, 2015, 8:40 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/BUILD, line 29 > > > > > > How about "kaurora" > > Maxim Khutornenko wrote: > This is a joke, right? :) If not I am r

Re: Review Request 32541: Adding client Kerberos support.

2015-04-02 Thread Kevin Sweeney
> On April 1, 2015, 1:40 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/BUILD, line 29 > > > > > > How about "kaurora" > > Maxim Khutornenko wrote: > This is a joke, right? :) If not I am r

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Maxim Khutornenko
> On April 1, 2015, 8:40 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/common/auth/auth_kerberos.py, line 33 > > > > > > An explanatory comment as to why we don't enable mutual authentication > > would b

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review78629 --- Master (4b9c759) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/ --- (Updated April 2, 2015, 1:10 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Maxim Khutornenko
> On April 1, 2015, 8:40 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/BUILD, line 29 > > > > > > How about "kaurora" This is a joke, right? :) If not I am really struggling how it would be mo

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review78573 --- Ship it! Looking good modulo comments below. Have you had a chance

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review78583 --- Ship it! Master (4b9c759) is green with this patch. ./build-suppo

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Maxim Khutornenko
> On March 31, 2015, 7:30 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/common/auth/__init__.py, line 14 > > > > > > I see red here but I don't see any corresponding changes to import > > lines - were th

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/ --- (Updated April 1, 2015, 7:53 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 32541: Adding client Kerberos support.

2015-03-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review78390 --- src/main/python/apache/aurora/common/auth/__init__.py

Re: Review Request 32541: Adding client Kerberos support.

2015-03-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/#review78260 --- Master (3ab8a9e) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32541: Adding client Kerberos support.

2015-03-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541/ --- (Updated March 30, 2015, 9:09 p.m.) Review request for Aurora, Kevin Sweeney an