Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-09 Thread Zameer Manji
> On July 9, 2015, 12:47 p.m., Stephan Erb wrote: > > I have just looked into the debian packages and noticed that these are > > quite different (different resulting packages, different dependencies, > > different config such as cluster.json). Shoudn't we aim to make the > > packages more simi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review91174 --- I have just looked into the debian packages and noticed that these a

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90531 --- Ship it! Master (318b40d) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 7:25 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90592 --- Ship it! Master (60ef7f6) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 8:40 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90542 --- Ship it! Master (318b40d) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Bill Farner
> On July 6, 2015, 9:56 p.m., Bill Farner wrote: > > Ship It! I got as far as successfully building and installing all created RPMs. I did not go much beyond that as far as qualification - aside from auccessfully running `aurora` and starting up the scheduler. Thanks for the patch! - Bill

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90587 --- Ship it! Ship It! - Bill Farner On July 6, 2015, 9:41 p.m., Stev

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90560 --- Ship it! Master (318b40d) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:09 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:05 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90566 --- build-support/packaging/rpm/aurora.service (line 20)

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90567 --- Ship it! Master (318b40d) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
> On July 6, 2015, 9:20 p.m., Kevin Sweeney wrote: > > build-support/packaging/rpm/aurora.service, line 20 > > > > > > This is unnecessary according to [1]? > > > > Alternatively you should consider doing `c

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:01 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:41 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 6:30 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 6:28 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90522 --- Ship it! Master (318b40d) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 6:11 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90421 --- Ship it! Master (82aa097) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-05 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 12:44 a.m.) Review request for Aurora, Jake Farrell, Kev

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-05 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 12:32 a.m.) Review request for Aurora, Jake Farrell, Kev

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-05 Thread Steve Salevan
> On June 23, 2015, 2:55 p.m., Jake Farrell wrote: > > Are you able to update this Steve? would love to get this in for 0.9.0 The latest patch incorporates the above changes; let me know what you think. - Steve --- This is an automatica

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-05 Thread Steve Salevan
> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote: > > packaging/rpm/aurora.service, line 21 > > > > > > The scheduler should not run as root Added support for the creation of an aurora user/group as well as logic to

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-05 Thread Steve Salevan
> On June 9, 2015, 3:49 p.m., Jake Farrell wrote: > > Patch looks good. Would like to see this move from top level /packaging to > > build-support/packaging and have docs/packaging.md or > > build-support/packaging/README.md added with some details for anyone that > > may not be familiar with

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-06-23 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review88987 --- Are you able to update this Steve? would love to get this in for 0.9

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-06-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review82436 --- Looks mostly good, few comments below. packaging/rpm/aurora.servic

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-06-09 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review87208 --- Patch looks good. Would like to see this move from top level /packag

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-25 Thread Dave Lester
> On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/aurora.spec, line 117 > > > > > > Since docker support is still beta, perhaps put this behind a flag and > > only install if desired? > > Steve Salevan

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-22 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review85038 --- Ship it! Ship It! - Joe Smith On May 19, 2015, 9:19 a.m., Steve

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-20 Thread Joe Smith
> On May 10, 2015, 7:53 p.m., Joe Smith wrote: > > packaging/rpm/aurora.spec, line 117 > > > > > > Since docker support is still beta, perhaps put this behind a flag and > > only install if desired? > > Steve Salevan

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review84332 --- Ship it! Master (920263b) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-19 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 19, 2015, 4:19 p.m.) Review request for Aurora, Jake Farrell, Kevi

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review84265 --- Ship it! Master (920263b) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-18 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 19, 2015, 6 a.m.) Review request for Aurora, Jake Farrell, Kevin S

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-18 Thread Steve Salevan
> On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/Makefile, line 15 > > > > > > My hunch is we should grab this from either the requirements.txt or the > > java dep, vs. specifying it here > > Zameer Ma

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-10 Thread Zameer Manji
> On May 10, 2015, 7:53 p.m., Joe Smith wrote: > > packaging/rpm/Makefile, line 15 > > > > > > My hunch is we should grab this from either the requirements.txt or the > > java dep, vs. specifying it here +1. We don't

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review83195 --- packaging/rpm/Makefile

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review82980 --- Ship it! Master (8157181) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-07 Thread Steve Salevan
> On May 4, 2015, 7:31 p.m., Bill Farner wrote: > > We've had success with using vagrant to serve as test beds and build > > environments for things like this [1]. Docker might be a boon here, as we > > can use that in ASF's jenkins. > > > > Don't hesitate to punt on this for now, as it's not

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-07 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 8, 2015, 5:08 a.m.) Review request for Aurora, Jake Farrell, Kevin

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-07 Thread Jake Farrell
> On May 4, 2015, 7:31 p.m., Bill Farner wrote: > > We've had success with using vagrant to serve as test beds and build > > environments for things like this [1]. Docker might be a boon here, as we > > can use that in ASF's jenkins. > > > > Don't hesitate to punt on this for now, as it's not

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review82421 --- We've had success with using vagrant to serve as test beds and build

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review82313 --- Ship it! Master (5fc7baf) is green with this patch. ./build-suppo

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-01 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 2, 2015, 5:20 a.m.) Review request for Aurora. Changes ---

Review Request 33778: Adds RPM specfile and support scripting

2015-05-01 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- Review request for Aurora. Bugs: AURORA-1116 https://issues.apache.org/jira