Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-08 Thread Bill Farner
> On May 8, 2015, 2:49 a.m., Zameer Manji wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 200 > > > > > > Shouldn't we abort if the response is not OK? Also how does this work > > when the schedule

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-08 Thread Bill Farner
> On May 8, 2015, 1:08 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 205 > > > > > > Since this is also used in "update wait" command, suggest reprhasing to > > something

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82968 --- src/main/python/apache/aurora/client/cli/update.py

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82959 --- Ship it! Master (9634d25) is green with this patch. ./build-suppo

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82958 --- Ship it! src/main/python/apache/aurora/client/cli/update.py

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 8, 2015, 1:04 a.m.) Review request for Aurora, Kevin Sweeney and Z

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82956 --- This patch does not apply cleanly on master (9634d25), do you need t

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 8, 2015, 12:44 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 8, 2015, 12:43 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 122 > > > > > > Suggest "--wait-until" for consistency with job create command. > > Bill Farner wrote

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 122 > > > > > > Suggest "--wait-until" for consistency with job create command. > > Bill Farner wrote

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Zameer Manji
> On May 7, 2015, 5:04 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 122 > > > > > > Suggest "--wait-until" for consistency with job create command. > > Bill Farner wrote:

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 122 > > > > > > Suggest "--wait-until" for consistency with job create command. > > Bill Farner wrote

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 122 > > > > > > Suggest "--wait-until" for consistency with job create command. > > Bill Farner wrote

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82944 --- Ship it! Master (27b5e25) is green with this patch. ./build-suppo

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 122 > > > > > > Suggest "--wait-until" for consistency with job create command. `--wait-until` accept

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82942 --- src/main/python/apache/aurora/client/cli/update.py

Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1239