Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84990 --- Master (998993d) is red with this patch.

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84992 --- src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Maxim Khutornenko
On May 22, 2015, 8:52 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 186 https://reviews.apache.org/r/34440/diff/2-3/?file=964680#file964680line186 Add @Positive here as well. Well, this can and should be 0 as well. We start

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- (Updated May 22, 2015, 8:56 p.m.) Review request for Aurora, Ben Mahler,

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84999 --- Ship it! Master (998993d) is green with this patch.

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Maxim Khutornenko
On May 19, 2015, 11:48 p.m., Zameer Manji wrote: Does it make sense for the reconciler to run in parallel with the GC executor mechanism? It seems fine to me, but I would like some re-assurance here. Maxim Khutornenko wrote: GC executor is not adding anything when task

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Joshua Cohen
On May 22, 2015, 8:52 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 186 https://reviews.apache.org/r/34440/diff/2-3/?file=964680#file964680line186 Add @Positive here as well. Maxim Khutornenko wrote: Well, this can and

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- (Updated May 22, 2015, 8:47 p.m.) Review request for Aurora, Ben Mahler,

Re: Review Request 34440: Implementing task reconciler.

2015-05-19 Thread Ben Mahler
On May 20, 2015, 12:44 a.m., Ben Mahler wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, lines 186-189 https://reviews.apache.org/r/34440/diff/1/?file=964437#file964437line186 Something to consider is that the important time to reconcile is after any

Re: Review Request 34440: Implementing task reconciler.

2015-05-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84421 --- Does it make sense for the reconciler to run in parallel with the

Re: Review Request 34440: Implementing task reconciler.

2015-05-19 Thread Zameer Manji
On May 19, 2015, 4:48 p.m., Zameer Manji wrote: Does it make sense for the reconciler to run in parallel with the GC executor mechanism? It seems fine to me, but I would like some re-assurance here. Maxim Khutornenko wrote: GC executor is not adding anything when task

Review Request 34440: Implementing task reconciler.

2015-05-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- Review request for Aurora, Ben Mahler, Kevin Sweeney, and Zameer Manji. Bugs: