Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
> On June 23, 2015, 7:46 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, > > line 242 > > > > > > s/manager/handler/ Done. - Maxim ---

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/ --- (Updated June 23, 2015, 8:39 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review89039 --- Ship it! src/main/java/org/apache/aurora/scheduler/mesos/MesosSche

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review89026 --- Ship it! Master (68c4620) is green with this patch. ./build-suppo

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/ --- (Updated June 23, 2015, 6:35 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
> On June 23, 2015, 5:55 p.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line > > 167 > > > > > > Accessing the Impl suggests an encapsulagion problem. Can you use th

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review89008 --- LGTM overall, will give a ship once the rebase comes out green. sr

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review88977 --- This patch does not apply cleanly on master (2df2db9), do you need t

Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1334 https://issues