Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Maxim Khutornenko
On Aug. 4, 2015, 6:57 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, line 154 https://reviews.apache.org/r/37049/diff/1/?file=1028142#file1028142line154 This seems like a new pattern that's inconsistent with the

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/ --- (Updated Aug. 5, 2015, 6:51 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/#review94282 --- src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/#review94283 --- Ship it! Master (2130f7e) is green with this patch.

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Maxim Khutornenko
On Aug. 5, 2015, 7:03 p.m., Maxim Khutornenko wrote: src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, lines 192-197 https://reviews.apache.org/r/37049/diff/2/?file=1032776#file1032776line192 Are you certain this is no longer needed? The setup above is shared

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/#review94101 --- LGTM. A few comments/questions below.

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/#review93983 --- Ship it! Master (7fdcfef) is green with this patch.

Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1395