Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 25, 2015, 11:02 a.m.) Review request for Aurora, Jake Farrell, Ke

Re: Review Request 37666: Import of Twitter Commons.

> On Aug. 25, 2015, 8:18 a.m., Joshua Cohen wrote: > > .gitignore, lines 13-14 > > > > > > keep the contents of this file alpha-sorted? Done. > On Aug. 25, 2015, 8:18 a.m., Joshua Cohen wrote: > > build.gradle, lin

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96339 --- Ship it! .gitignore (lines 13 - 14)

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96293 --- Ship it! Master (cb84ed2) is green with this patch. ./build-suppo

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 24, 2015, 8:27 p.m.) Review request for Aurora, Jake Farrell, Kev

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 24, 2015, 8:12 p.m.) Review request for Aurora, Jake Farrell, Kev

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96270 --- This patch does not apply cleanly on master (f202f2d), do you need t

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96267 --- Ship it! +1 with the known requirement that there will be a follow

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96258 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 25, 2015, 12:03 a.

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96250 --- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 12:03 a.m., Za

Re: Review Request 37666: Import of Twitter Commons.

> On Aug. 21, 2015, 11:04 a.m., Maxim Khutornenko wrote: > > It would be great to preserve all commit history with this import. Any > > chance you could follow the sapling split procedure? It's a bit involved > > but pretty well documented here: https://github.com/jsirois/sapling > > Zameer Ma

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 24, 2015, 5:03 p.m.) Review request for Aurora, Jake Farrell, Kev

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96241 --- Ship it! build.gradle (line 128)

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 24, 2015, 4:54 p.m.) Review request for Aurora, Jake Farrell, Kev

Re: Review Request 37666: Import of Twitter Commons.

> On Aug. 21, 2015, 6:04 p.m., Maxim Khutornenko wrote: > > It would be great to preserve all commit history with this import. Any > > chance you could follow the sapling split procedure? It's a bit involved > > but pretty well documented here: https://github.com/jsirois/sapling > > Zameer Man

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96070 --- Integration LGTM. build.gradle (line 136)

Re: Review Request 37666: Import of Twitter Commons.

> On Aug. 21, 2015, 11:04 a.m., Maxim Khutornenko wrote: > > It would be great to preserve all commit history with this import. Any > > chance you could follow the sapling split procedure? It's a bit involved > > but pretty well documented here: https://github.com/jsirois/sapling Once the revi

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96066 --- This patch does not apply cleanly on master (f4446a6), do you need t

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96062 --- It would be great to preserve all commit history with this import. A

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 21, 2015, 11:02 a.m.) Review request for Aurora, Jake Farrell, Ke

Re: Review Request 37666: Import of Twitter Commons.

> On Aug. 21, 2015, 8:41 a.m., Kevin Sweeney wrote: > > commons-args/src/main/java/com/twitter/common/args/Arg.java, line 1 > > > > > > Strip the Twitter header here and replace it with the standard > > license-header

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96048 --- build.gradle (line 93)

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96018 --- I would like reviewers to pay special attention to changes made in b

Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- Review request for Aurora, Jake Farrell, Kevin Sweeney, Maxim Khutornenko, and B