Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/ --- (Updated Sept. 15, 2015, 7:35 p.m.) Review request for Aurora and Joshua

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review99157 --- Master (44e4726) is green with this patch.

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-15 Thread Bill Farner
> On Sept. 14, 2015, 11:01 a.m., Kevin Sweeney wrote: > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java, > > lines 72-73 > > > > > > Will this ever appear to the client?

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-15 Thread Bill Farner
> On Sept. 14, 2015, 9:19 a.m., Joshua Cohen wrote: > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java, > > line 78 > > > > > > nit, not even related to your change, but this can

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98858 --- Ship it! Couple of nits, lgtm in general.

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-14 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98877 --- Ship it!

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-13 Thread Bill Farner
> On Sept. 12, 2015, 5:37 p.m., Aurora ReviewBot wrote: > > Master (5dccf92) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > :processJmhResources UP-TO-DATE > > :jmhClasses > > :checkstyleJmh > > :jsHint > > :checkstyleMain > > :compileTestJavaNote: Some input files

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98781 --- Maybe we should move these endpoints out of commons and into

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98757 --- Master (5dccf92) is red with this patch.