Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106870 --- Ship it! Ship It! - Bill Farner On Nov. 17, 2015, 6:56 a.m., Jo

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106868 --- Ship it! Master (86761e8) is green with this patch. ./build-supp

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread John Sirois
> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote: > > build-support/thrift/Makefile, line 28 > > > > > > The ticket says this patch was committed in 0.9.2. Would it be more > > productive to upgrade to 0.9.2+ before

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 17, 2015, 7:56 a.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote: > > build-support/thrift/Makefile, line 28 > > > > > > The ticket says this patch was committed in 0.9.2. Would it be more > > productive to upgrade to 0.9.2+ before

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote: > > build-support/thrift/Makefile, line 28 > > > > > > The ticket says this patch was committed in 0.9.2. Would it be more > > productive to upgrade to 0.9.2+ before

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106749 --- Ship it! build-support/thrift/Makefile (line 26)

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106726 --- Ship it! Master (86761e8) is green with this patch. ./build-supp

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 16, 2015, 1:11 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 16, 2015, 1:05 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106668 --- Master (7b494f4) is red with this patch. ./build-support/jenkins/

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 16, 2015, 8:28 a.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote: > > Heh, took a few rounds to understand what was going on > > here...case-insensitive file system strikes again! > > ``` > > ... > > Making install in lib > > /Library/Developer/CommandLineTools/usr/bin/make install-am > > if test no = no; the

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote: > > Heh, took a few rounds to understand what was going on > > here...case-insensitive file system strikes again! > > ``` > > ... > > Making install in lib > > /Library/Developer/CommandLineTools/usr/bin/make install-am > > if test no = no; the

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 16, 2015, 8:13 a.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106597 --- Heh, took a few rounds to understand what was going on here...case-

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 9:27 p.m., Aurora ReviewBot wrote: > > Master (7b494f4) is red with this patch. > > ./build-support/jenkins/build.sh > > > > 04:22:02 00:00 [ivy-imports] > > 04:22:02 00:00 [unpack-jars] > > 04:22:02 00:00 [unpack-jars] > > 04:22:02 00:00 [jvm-platform-validate]

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106591 --- Master (7b494f4) is red with this patch. ./build-support/jenkins/

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 15, 2015, 9:13 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote: > > build-support/thrift/Makefile, line 50 > > > > > > On OS X 10.11 i get the following from this line: > > ``` > > sha256=$(curl -s https://ftp.gnu.org/gnu/b

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 7:57 p.m., Aurora ReviewBot wrote: > > Master (7b494f4) is red with this patch. > > ./build-support/jenkins/build.sh > > > > 02:52:16 00:00 [ivy-imports] > > 02:52:16 00:00 [unpack-jars] > > 02:52:16 00:00 [unpack-jars] > > 02:52:16 00:00 [deferred-sources] > >

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106588 --- Master (7b494f4) is red with this patch. ./build-support/jenkins/

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106587 --- Stephan - not sure if you tested this patch on your Arch, but I'd a

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 15, 2015, 7:45 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote: > > build-support/thrift/.gitignore, line 1 > > > > > > How about wildcards so we don't trip over this when upgrading > > bison/thrift? Sounds good - done. > On Nov

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote: > > build-support/thrift/Makefile, line 50 > > > > > > On OS X 10.11 i get the following from this line: > > ``` > > sha256=$(curl -s https://ftp.gnu.org/gnu/b

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106577 --- build-support/thrift/.gitignore (line 1)

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106558 --- Ship it! A working build on Arch, thanks for that\! - Stephan Erb

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106550 --- Ship it! Master (7b494f4) is green with this patch. ./build-supp

Review Request 40323: Improve the isolation in the thrift build.

2015-11-14 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora D