Re: Review Request 41777: Use slf4j throughout the scheduler.

2016-01-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41777/#review112479 --- Ship it! - Zameer Manji On Dec. 29, 2015, 4:06 p.m., Bill

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41777/#review112270 --- Ship it! Master (80ae5e8) is green with this patch.

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread John Sirois
> On Dec. 29, 2015, 3:15 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, line > > 100 > > > > > > This now always logs all the fast queries - I don't think you

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Bill Farner
> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote: > > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java, > > line 363 > > > > > > This branch is a perf-change since the message is now

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41777/#review112233 --- Ship it! Master (80ae5e8) is green with this patch.

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41777/#review112263 --- Ship it!

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Bill Farner
> On Dec. 29, 2015, 3:59 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java, line 125 > > > > > > You can use {}'s and drop the guard now. Doh, thought i did that.

Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41777/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora