Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2016-01-05 Thread Bill Farner
> On Jan. 4, 2016, 12:46 p.m., Maxim Khutornenko wrote: > > Has the high level plan been discussed on dev list before or is it the > > first time this proposal is shaped up? It would be great to have an > > official design summary or at least a ticket capturing the goals of this > >

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2016-01-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review112886 --- +1 to the proposed approach. I think the idea of encapsulating all

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2016-01-05 Thread Zameer Manji
> On Dec. 30, 2015, 4:14 p.m., John Sirois wrote: > > I'd be happy with these commits landing as they come, but I'll recommend > > that be paired with a boilerplate comment referencing a tracking jira issue > > that explains the odd interfaces appearing during the transition. +1 to landing

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2016-01-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review112643 --- Has the high level plan been discussed on dev list before or is it

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2015-12-30 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review112363 --- Ship it! I'd be happy with these commits landing as they come,

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2015-12-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review112365 --- Master (aac7aad) is red with this patch.