Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115250 --- Master (317aa4d) is green with this patch. ./build-support/jenkin

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115244 --- Ship it! Looking forward to the followup change that collapses som

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Zameer Manji
> On Jan. 19, 2016, 8:34 a.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java, > > line 67 > > > > > > The defaults aren't applied consistently here, not sometimes at

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115197 --- Ship it! Ship It! - John Sirois On Jan. 19, 2016, 10:49 a.m., B

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/ --- (Updated Jan. 19, 2016, 9:49 a.m.) Review request for Aurora, John Sirois and Z

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Bill Farner
> On Jan. 19, 2016, 9:36 a.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java, > > line 168 > > > > > > The comment can go now that this is wrapped in a presen

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115191 --- Ship it! src/main/java/org/apache/aurora/scheduler/log/mesos/Meso

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/ --- (Updated Jan. 19, 2016, 9:31 a.m.) Review request for Aurora, John Sirois and Z

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Bill Farner
> On Jan. 19, 2016, 8:34 a.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java, > > line 178 > > > > > > This will need some adjustment to keep the improved failu

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115175 --- Ship it! src/main/java/org/apache/aurora/scheduler/log/mesos/Meso

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115091 --- Master (b563679) is green with this patch. ./build-support/jenkin

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/ --- (Updated Jan. 18, 2016, 4:26 p.m.) Review request for Aurora, John Sirois and Z