Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115911 --- Ship it! Ship It! - Bill Farner On Jan. 21, 2016, 6:47 p.m., Jo

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115782 --- Ship it! Ship It! - Zameer Manji On Jan. 21, 2016, 6:47 p.m., J

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115777 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 22, 2016, 2:47 a.

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115774 --- Ship it! Master (c89fecb) is green with this patch. ./build-supp

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-21 Thread John Sirois
> On Jan. 21, 2016, 7:58 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/GuavaUtils.java, line 63 > > > > > > Would not AbstractIdleService suffice your needs here? > > http://docs.guava-libraries.

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-21 Thread John Sirois
> On Jan. 21, 2016, 7:52 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 169 > > > > > > Is it safe to call this method from multiple threads? Nothing

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115770 --- src/main/java/org/apache/aurora/GuavaUtils.java (line 63)

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115768 --- src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrune

Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

2016-01-21 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/ --- Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji. Bu