Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117471 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 1172)

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/ --- (Updated Feb. 2, 2016, 8:48 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117488 --- Ship it! Ship It! - Zameer Manji On Feb. 2, 2016, 1:51

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen
> On Feb. 1, 2016, 8:41 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java, > > line 64 > > > > > > Mini drive-by, but personally i'd rather just see `!= null`

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117473 --- Ship it! Master (3fc9dc2) is green with this patch.

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117491 --- Ship it! Thanks for adding the test coverage! - Bill Farner

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen
> On Feb. 2, 2016, 9:29 p.m., Bill Farner wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1172 > > > > > > Nit - rather than track the class name `LeaderRedirectFilter`, refer to > > the

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117516 --- Ship it! Master (2f485e8) is green with this patch.

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117258 --- Ship it! Master (de0029b) is green with this patch.

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117260 --- Fix it, then Ship it!

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117261 ---

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117259 --- src/main/python/apache/aurora/client/api/scheduler_client.py

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/ --- (Updated Feb. 1, 2016, 8:05 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Joshua Cohen
> On Jan. 29, 2016, 9:07 p.m., Zameer Manji wrote: > > I think you also need to add a flag/option to `aurora_admin` to let > > operators take advantage of this flag. Done! - Joshua --- This is an automatically generated e-mail. To

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Joshua Cohen
> On Jan. 29, 2016, 10:42 p.m., Stephan Erb wrote: > > If this is crucial for recovery, this should really be documented. Yeah, for sure. I filed https://issues.apache.org/jira/browse/AURORA-1605 to track updating the recovery docs. - Joshua

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117036 --- If this is crucial for recovery, this should really be

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117026 --- Ship it! Master (0eb753d) is green with this patch.

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/ --- (Updated Jan. 29, 2016, 8:54 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Joshua Cohen
> On Jan. 29, 2016, 9:07 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java, > > line 45 > > > > > > Since this is a custom header perhaps we should prefix it with

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-01-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117013 --- I think you also need to add a flag/option to `aurora_admin` to