Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 25, 2016, 11:18 p.m.) Review request for Aurora, Joshua Cohen, B

Re: Review Request 46459: Schema changes for resource management refactoring

> On April 25, 2016, 2:34 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java, > > line 107 > > > > > > Should we pull `ResourceType.findByResource(e)` up to a v

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130507 --- Ship it! Ship It! - Bill Farner On April 22, 2016, 5:16 p.m.

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130506 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 5:16 p.m

Re: Review Request 46459: Schema changes for resource management refactoring

> On April 24, 2016, 4:01 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line > > 114 > > > > > > Generalizing all resources to varchar type is quite unfortunate.

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130417 --- Ship it! lgtm, just a few nits below. src/main/java/org/apach

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130308 --- src/main/resources/org/apache/aurora/scheduler/storage/db/schema.

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130229 --- Ship it! Master (d339036) is green with this patch. ./build-s

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 23, 2016, 12:16 a.m.) Review request for Aurora, Joshua Cohen, B

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130215 --- Ship it! Master (95dcca5) is green with this patch. ./build-s

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 22, 2016, 10:48 p.m.) Review request for Aurora, Joshua Cohen, B

Re: Review Request 46459: Schema changes for resource management refactoring

> On April 22, 2016, 6:55 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java, > > line 210 > > > > > > Instead of having a switch statement here, perhaps it

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130140 --- src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBod

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130120 --- Master (95dcca5) is red with this patch. ./build-support/jenkins

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 22, 2016, 4:45 p.m.) Review request for Aurora, Joshua Cohen, Bi

Re: Review Request 46459: Schema changes for resource management refactoring

> On April 22, 2016, 3:15 p.m., Joshua Cohen wrote: > > Overall looks good to me. One question though: what happens in the scenario > > where we receive a TaskConfig that has both the individual task-level > > resources populated as well as the new resource collection. Further, what > > happen

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130096 --- Overall looks good to me. One question though: what happens in the

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review129986 --- Ship it! Master (95dcca5) is green with this patch. ./build-s

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 21, 2016, 11:03 p.m.) Review request for Aurora, Joshua Cohen, B

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review129971 --- Master (95dcca5) is red with this patch. ./build-support/jenkins

Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji. Reposit