Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review132544 --- Ship it! Master (77c465a) is green with this patch.

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

> On May 10, 2016, 8:48 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java, > > lines 132-134 > > > > > > Could you please double check the comment? It does

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review132527 --- Ship it! LGTM

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review132503 --- Ship it! Ship It! - Joshua Cohen On May 10, 2016, 5:54

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- (Updated May 10, 2016, 5:54 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review132492 --- This patch does not apply cleanly against RB#46997 (77c465a), do

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- (Updated May 10, 2016, 5:36 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review132357 ---

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- (Updated May 6, 2016, 8:22 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review132097 --- Master (3687c6a) is red with this patch.

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- (Updated May 6, 2016, 7:41 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review131984 --- Ship it! Master (f25a4b1) is green with this patch.

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- (Updated May 6, 2016, 1:58 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

> On May 6, 2016, 1:54 a.m., John Sirois wrote: > > I put some effort into to supporting feathered RBs, you can put 46997 in > > the `depends on` field and the AuroraBot will apply its diff 1st, then this > > diff on top... currently only works for 1 parent. Aha, thanks for the pointer! -

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review131981 --- I put some effort into to supporting feathered RBs, you can put

Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora