Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146582 --- Ship it! This makes me a little nervous, but I don't think

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146578 --- Ship it! Ship It! - Stephan Erb On Aug. 23, 2016, 10:45

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Stephan Erb
> On Aug. 23, 2016, 11:20 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/helper.py, lines 104-109 > > > > > > In the non-docker usecase, Thermos will by default run as uid 0 and > > setuid

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Zameer Manji
> On Aug. 23, 2016, 2:20 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/helper.py, lines 104-109 > > > > > > In the non-docker usecase, Thermos will by default run as uid 0 and > > setuid launched

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146574 --- src/main/python/apache/thermos/core/helper.py (lines 104 - 109)

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146571 --- Ship it! Master (c115ac6) is green with this patch.