Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147900 --- This change is now on master at `0c90c862a14c3a5efe0fdf0f30ee41c01

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147899 --- Ship it! Ship It! - Zameer Manji On Sept. 5, 2016, 11:56 a.m

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147855 --- Ship it! Ship It! - Joshua Cohen On Sept. 5, 2016, 6:56 p.m.

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147853 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 5, 2016, 6:56

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147781 --- Ship it! Ship It! - Stephan Erb On Sept. 5, 2016, 8:56 nachm

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Kai Huang
> On Sept. 3, 2016, 10:14 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java, line 76 > > > > > > Please update the documentation to cover the new SLA metric > > https://gith

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review14 --- Ship it! Master (5d3f945) is green with this patch. ./build-s

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/ --- (Updated Sept. 5, 2016, 6:56 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Kai Huang
> On Sept. 1, 2016, 7:53 p.m., Zameer Manji wrote: > > Can you set the depends on field of this review to be `51536`? So we know > > that this patch is blocked on that review landing first? > > Stephan Erb wrote: > Is it really blocked? Nothing would be wrong or broken if we submit this >

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147730 --- src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java (

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-03 Thread Stephan Erb
> On Sept. 1, 2016, 9:53 p.m., Zameer Manji wrote: > > Can you set the depends on field of this review to be `51536`? So we know > > that this patch is blocked on that review landing first? Is it really blocked? Nothing would be wrong or broken if we submit this right away. - Stephan -

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/ --- (Updated Sept. 1, 2016, 8:19 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147600 --- Ship it! Master (bd11b1c) is green with this patch. ./build-s

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147598 --- Can you set the depends on field of this review to be `51536`? So

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/ --- (Updated Sept. 1, 2016, 7:37 p.m.) Review request for Aurora, Joshua Cohen, Max

Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/ --- Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji. R