Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review149099 --- Ship it! Ship It!

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review149066 --- Ship it! Patch LGTM. In general, I don't like the trend that

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review149065 --- Ship it! Master (5069f93) is green with this patch.

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/ --- (Updated Sept. 15, 2016, 3:15 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Joshua Cohen
> On Sept. 15, 2016, 1:23 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 73 > > > > > > You pass in `_cmd` and `_isolator_fn` into the `ShellHealthCheck`. Have > > you

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review149056 --- src/main/python/apache/aurora/common/health_check/shell.py (line

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review148970 --- Ship it! Master (5069f93) is green with this patch.

Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/ --- Review request for Aurora, Stephan Erb and Zhitao Li. Repository: aurora