Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/ --- Review request for Aurora, Maxim Khutornenko, Mehrdad Nurolahzade, and Zameer Ma

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149604 --- Master (4c4040f) is red with this patch. ./build-support/jenkins

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/ --- (Updated Sept. 20, 2016, 6:08 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149698 --- Ship it! Master (4745c8c) is green with this patch. ./build-s

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149709 --- Fix it, then Ship it! LGTM. I'm surprised at how small of a ri

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/ --- (Updated Sept. 20, 2016, 7:14 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149712 --- Ship it! Master (4745c8c) is green with this patch. ./build-s

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149714 --- src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImpl

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149715 --- Ship it! Ship It! - Mehrdad Nurolahzade On Sept. 20, 2016, 1

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149862 --- Ship it! src/main/java/org/apache/aurora/scheduler/mesos/Sched

Re: Review Request 52074: switching from launchTask to acceptOffers

> On Sept. 21, 2016, 5:54 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java, line 372 > > > > > > Can be inlined below. Done. > On Sept. 21, 2016, 5:54 p.m., Max

Re: Review Request 52074: switching from launchTask to acceptOffers

> On Sept. 20, 2016, 7:41 p.m., Mehrdad Nurolahzade wrote: > > src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java, > > lines 52-56 > > > > > > We should start disallowing or limiting import st

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149869 --- src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImpl

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/ --- (Updated Sept. 21, 2016, 6:19 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/ --- (Updated Sept. 21, 2016, 6:23 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149875 --- Master (8432894) is red with this patch. ./build-support/jenkins

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/ --- (Updated Sept. 21, 2016, 6:51 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 52074: switching from launchTask to acceptOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149883 --- Ship it! Master (8432894) is green with this patch. ./build-s