Re: Review Request 52669: Move the H2 database off heap.

2017-04-17 Thread David McLaughlin
> On April 17, 2017, 11:09 a.m., Stephan Erb wrote: > > David, you mentioned on the mailinglist that off-heap storage only offered > > marginal improvements. I suppse I can therefore discard this patch? We'll give it one last shot in our scale test environment (it finally looks like we've

Re: Review Request 52669: Move the H2 database off heap.

2017-04-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review172078 --- David, you mentioned on the mailinglist that off-heap storage

Re: Review Request 52669: Move the H2 database off heap.

2017-02-09 Thread David McLaughlin
> On Feb. 9, 2017, 5:11 p.m., David McLaughlin wrote: > > Early scale testing of this has been promising in terms of relieving GC > > pressure (although not a silver bullet by any means), but query latency was > > orders of magnitude slower. At certain task volumes (500k total tasks in > >

Re: Review Request 52669: Move the H2 database off heap.

2017-02-09 Thread Zameer Manji
> On Feb. 9, 2017, 9:11 a.m., David McLaughlin wrote: > > Early scale testing of this has been promising in terms of relieving GC > > pressure (although not a silver bullet by any means), but query latency was > > orders of magnitude slower. At certain task volumes (500k total tasks in > >

Re: Review Request 52669: Move the H2 database off heap.

2017-02-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review164942 --- Early scale testing of this has been promising in terms of

Re: Review Request 52669: Move the H2 database off heap.

2016-12-28 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review160224 --- I have just run this patch on top of

Re: Review Request 52669: Move the H2 database off heap.

2016-10-31 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review154296 --- A new h2 version (http://h2database.com/html/changelog.html) was

Re: Review Request 52669: Move the H2 database off heap.

2016-10-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review152175 --- Master (e9abb22) is green with this patch.

Re: Review Request 52669: Move the H2 database off heap.

2016-10-11 Thread Stephan Erb
> On Oct. 10, 2016, 12:39 a.m., John Sirois wrote: > > I don't think the micro-benchmarks show anything really. The error bars > > for the off-heap are generally larger than the values themselves! I imagine > > jmh is simply not the right tool for testing off-heap. > > I too though am

Re: Review Request 52669: Move the H2 database off heap.

2016-10-11 Thread Stephan Erb
> On Oct. 10, 2016, 8:51 p.m., Zameer Manji wrote: > > build.gradle, line 94 > > > > > > Can you please peel off the rev bumps on to their own patch? We should > > land them anyways. Done. I have filed

Re: Review Request 52669: Move the H2 database off heap.

2016-10-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review152038 --- This is really neat, I will try to play with as well.

Re: Review Request 52669: Move the H2 database off heap.

2016-10-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review151990 --- Master (09b8e58) is green with this patch.

Re: Review Request 52669: Move the H2 database off heap.

2016-10-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review151985 --- Neat! I'll try and get this applied to our test clusters at

Re: Review Request 52669: Move the H2 database off heap.

2016-10-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/ --- (Updated Oct. 10, 2016, 5:14 p.m.) Review request for Aurora, David

Re: Review Request 52669: Move the H2 database off heap.

2016-10-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review151970 --- Master (09b8e58) is red with this patch.

Re: Review Request 52669: Move the H2 database off heap.

2016-10-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/ --- (Updated Oct. 10, 2016, 2:53 p.m.) Review request for Aurora, David

Re: Review Request 52669: Move the H2 database off heap.

2016-10-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review151946 --- Master (09b8e58) is green with this patch.

Re: Review Request 52669: Move the H2 database off heap.

2016-10-09 Thread Stephan Erb
> On Oct. 10, 2016, 12:39 a.m., John Sirois wrote: > > I don't think the micro-benchmarks show anything really. The error bars > > for the off-heap are generally larger than the values themselves! I imagine > > jmh is simply not the right tool for testing off-heap. > > I too though am

Re: Review Request 52669: Move the H2 database off heap.

2016-10-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/ --- (Updated Oct. 10, 2016, 12:41 a.m.) Review request for Aurora, David

Re: Review Request 52669: Move the H2 database off heap.

2016-10-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review151943 --- I don't think the micro-benchmarks show anything really. The

Review Request 52669: Move the H2 database off heap.

2016-10-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/ --- Review request for Aurora, David McLaughlin, John Sirois, and Zameer Manji.