Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152972 --- Master (ac8b802) is green with this patch. ./build-support/jenki

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/ --- (Updated Oct. 17, 2016, 11:52 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152964 --- This patch does not apply cleanly against master (ac8b802), do you

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/ --- (Updated Oct. 17, 2016, 11:24 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152917 --- Ship it! Ship It! - Zameer Manji On Oct. 13, 2016, 2:27 a.m.

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152887 --- Ship it! Thanks for clarifying re: calling the supplier in the

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-17 Thread Stephan Erb
> On Oct. 13, 2016, 10:24 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 215 > > > > > > Is there a reason we can't apply the `get` call here rather tha

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-13 Thread Zameer Manji
> On Oct. 13, 2016, 1:24 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 215 > > > > > > Is there a reason we can't apply the `get` call here rather than

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152571 --- src/main/java/org/apache/aurora/scheduler/resources/ResourceType.

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152477 --- Master (8256000) is green with this patch. ./build-support/jenki

Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1794