Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review158490 --- Ship it! Ship It! - Joshua Cohen On Dec. 8, 2016, 12:15 a.m.

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review158456 --- Ship it! Master (91ddb07) is green with this patch. ./build-s

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-07 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/ --- (Updated Dec. 7, 2016, 4:15 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review158183 --- Ship it! Master (4bc5246) is green with this patch. ./build-s

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-06 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review158182 --- Ship it! Ship It! - David McLaughlin On Dec. 6, 2016, 4:32 p

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-06 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/ --- (Updated Dec. 6, 2016, 5:32 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-04 Thread Santhosh Kumar Shanmugham
> On Dec. 2, 2016, 11:54 a.m., Zameer Manji wrote: > > It took me a long time to understand this after staring at the tests, but I > > think this is correct. > > > > This is unfortunately a little complex to understand. For bonus points, > > would it be possible to encode some of this informat

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-04 Thread Santhosh Kumar Shanmugham
> On Dec. 2, 2016, 1:44 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/common/health_checker.py, lines > > 115-117 > > > > > > There still exists the chance for a backwards incompatibility here

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review157764 --- src/main/python/apache/aurora/executor/common/health_checker.py (

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review157807 --- Ship it! It took me a long time to understand this after starin

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review157722 --- Ship it! Master (3ea0331) is green with this patch. ./build-s

Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

2016-12-02 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, Stephan Erb, and Zame