Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review161591 --- Ship it! Ship It! - Zameer Manji On Jan. 13, 2017, 12:23

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-12 Thread Pradyumna Kaushik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/ --- (Updated Jan. 13, 2017, 1:02 a.m.) Review request for Aurora and Mehrdad

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-12 Thread Pradyumna Kaushik
> On Jan. 12, 2017, 10:17 p.m., Mehrdad Nurolahzade wrote: > > @ReviewBot retry I pulled the Apache master once again and I am going to update the review request. - Pradyumna --- This is an automatically generated e-mail. To reply,

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-12 Thread Pradyumna Kaushik
> On Jan. 12, 2017, 10:21 p.m., Aurora ReviewBot wrote: > > Master (06a221f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > thrift-0.9.1/tutorial/py/Makefile.in > > thrift-0.9.1/tutorial/py/PythonClient.py > > thrift-0.9.1/tutorial/py/PythonServer.py > >

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review161435 --- Master (06a221f) is red with this patch.

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-12 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review161434 --- @ReviewBot retry - Mehrdad Nurolahzade On Jan. 12, 2017, 1:17

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-12 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review161433 --- Ship it! @StephanErb or @jcohen Could you please join review

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review161421 --- Master (06a221f) is red with this patch.

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2017-01-12 Thread Pradyumna Kaushik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/ --- (Updated Jan. 12, 2017, 9:17 p.m.) Review request for Aurora and Mehrdad

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2016-12-24 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review160112 --- LGTM, except for the following minor changes.

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2016-12-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review160111 --- Ship it! Master (e2ca371) is green with this patch.

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2016-12-24 Thread Pradyumna Kaushik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/ --- (Updated Dec. 24, 2016, 4:01 p.m.) Review request for Aurora and Mehrdad

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2016-12-21 Thread Pradyumna Kaushik
> On Dec. 22, 2016, 1:23 a.m., Mehrdad Nurolahzade wrote: > > Could you please refactor away from `Stats`, as was suggested by @zmanji on > > a similar rb [https://reviews.apache.org/r/54959/]? @Mehrdad will do. - Pradyumna --- This

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2016-12-21 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review159902 --- Could you please refactor away from `Stats`, as was suggested by

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2016-12-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review159900 --- Master (38b9311) is green with this patch.

Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

2016-12-21 Thread Pradyumna Kaushik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/ --- Review request for Aurora and Mehrdad Nurolahzade. Repository: aurora