Re: Review Request 55019: AURORA-1851 Expose stats on JobUpdateAction transitions

2016-12-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55019/#review160158 --- Ship it! Ship It! - Stephan Erb On Dec. 24, 2016, 1:52 a.m.,

Re: Review Request 55019: AURORA-1851 Expose stats on JobUpdateAction transitions

2016-12-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55019/#review160109 --- Ship it! Master (e2ca371) is green with this patch. ./build-s

Re: Review Request 55019: AURORA-1851 Expose stats on JobUpdateAction transitions

2016-12-23 Thread Mehrdad Nurolahzade
> On Dec. 23, 2016, 2:51 p.m., Zameer Manji wrote: > > This LGTM. > > > > One issue I always find with these metrics is that they are dynamically > > generated (Based on enum name). However we do not initialize all of these > > values to 0 initially. This means that some of the enum values do

Re: Review Request 55019: AURORA-1851 Expose stats on JobUpdateAction transitions

2016-12-23 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55019/ --- (Updated Dec. 23, 2016, 4:52 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 55019: AURORA-1851 Expose stats on JobUpdateAction transitions

2016-12-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55019/#review160104 --- Ship it! This LGTM. One issue I always find with these metrics

Re: Review Request 55019: AURORA-1851 Expose stats on JobUpdateAction transitions

2016-12-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55019/#review160102 --- Ship it! Master (e2ca371) is green with this patch. ./build-s

Review Request 55019: AURORA-1851 Expose stats on JobUpdateAction transitions

2016-12-23 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55019/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-1851