Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review166465 --- Ship it! Ship It! - David McLaughlin On Jan. 28, 2017, 9:15

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review166427 --- Ship it! LGTM. - Stephan Erb On Jan. 28, 2017, 10:15 p.m.,

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review162822 --- Ping! - Mehrdad Nurolahzade On Jan. 9, 2017, 5:11 p.m.,

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review161021 --- Ship it! Master (d4ebb56) is green with this patch.

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/ --- (Updated Jan. 9, 2017, 5:11 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review160905 ---

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review160868 ---

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review160560 --- Ship it! Master (d4ebb56) is green with this patch.

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

> On Jan. 4, 2017, 10:48 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > lines 520-532 > > > > > > Can these be default methods on the interface

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/ --- (Updated Jan. 4, 2017, 8:36 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

> On Jan. 4, 2017, 9:59 a.m., Kai Huang wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 521 > > > > > > If we need this elsewhere, can we make the timing part more

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review160521 ---

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

> On Jan. 4, 2017, 9:59 a.m., Kai Huang wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 521 > > > > > > If we need this elsewhere, can we make the timing part more

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review160517 ---

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

> On Dec. 30, 2016, 1:37 p.m., Dmitriy Shirchenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 522 > > > > > > for my own knowledge: does Java have a similar

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review160304 ---

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review160303 --- Ship it! Master (21ad18e) is green with this patch.

Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/ --- Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: