Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review161126 --- Ship it! Ship It! - Stephan Erb On Jan. 10, 2017, 7 p.m., Jo

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review161125 --- Ship it! Master (d4ebb56) is green with this patch. ./build-s

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review161116 --- @ReviewBot retry - Stephan Erb On Jan. 10, 2017, 7 p.m., Joshua

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-10 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review161094 --- Ship it! LGTM. - Santhosh Kumar Shanmugham On Jan. 10, 2017,

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-10 Thread Joshua Cohen
> On Jan. 10, 2017, 6:15 p.m., Aurora ReviewBot wrote: > > Master (d4ebb56) is red with this patch. > > ./build-support/jenkins/build.sh > > > > INFO] Executor [None]:Reason: test_message > > INFO] Executor []:Reason: Task initialization > >

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review161091 --- Master (d4ebb56) is red with this patch. ./build-support/jenkins

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-10 Thread Joshua Cohen
> On Jan. 9, 2017, 7:28 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, lines 285-290 > > > > > > This looks suspicious. Creating a directory and then checking it does > > not

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/ --- (Updated Jan. 10, 2017, 6 p.m.) Review request for Aurora, Santhosh Kumar Shanm

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-09 Thread Joshua Cohen
> On Jan. 9, 2017, 10:57 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, lines 285-291 > > > > > > I tried a `mkdir` followed by `touch` and the path still continu

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-09 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review160995 --- src/main/python/apache/aurora/executor/common/sandbox.py (lines 2

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review160933 --- src/main/python/apache/aurora/executor/common/sandbox.py (lines 2

Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review160912 --- Ship it! Master (d4ebb56) is green with this patch. ./build-s

Review Request 55347: Ensure destination exists when mounting files into a filesystem image.

2017-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/ --- Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb. Repositor