Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

> On Feb. 14, 2017, 7:34 p.m., Zameer Manji wrote: > > Linking this to a ticket would be nice for posterity. > > > > This seems like a useful admin tool. Thanks for adding it. I would probably > > use this in cases where some large jobs go flapping and populate the DB > > with thousands of

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/ --- (Updated Feb. 14, 2017, 9:11 p.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165562 --- Ship it! Linking this to a ticket would be nice for posterity.

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

> On Feb. 14, 2017, 5:44 a.m., Santhosh Kumar Shanmugham wrote: > > LGTM modulo my pervious comment, > > > > "Since this command has the potential to hurt the Scheduler, should we make > > sure that atleast one of the filters is provided? Or force a minimum > > default limit to avoid

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165460 --- Ship it! Master (40d91fe) is green with this patch.

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165456 --- Ship it! LGTM modulo my pervious comment, "Since this command

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165450 --- Ship it! Master (40d91fe) is green with this patch.

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165448 --- Add entry in RELEASE-NOTES. - Santhosh Kumar Shanmugham On

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165447 ---

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

> On Feb. 13, 2017, 5:54 p.m., Reza Motamedi wrote: > > LGTM! > > > > But, should we test this in the test cluster? At least to check the effect > > of _limit_? > > David McLaughlin wrote: > I did test this in Vagrant. All the options work correctly. > > David McLaughlin wrote: >

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/ --- (Updated Feb. 14, 2017, 5:06 a.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

> On Feb. 13, 2017, 8:48 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > lines 1128-1129 > > > > > > Depending on th query this can be

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165440 ---

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

> On Feb. 14, 2017, 1:54 a.m., Reza Motamedi wrote: > > LGTM! > > > > But, should we test this in the test cluster? At least to check the effect > > of _limit_? > > David McLaughlin wrote: > I did test this in Vagrant. All the options work correctly. Weird, verifying the StateManager

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/ --- (Updated Feb. 14, 2017, 4:28 a.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/ --- (Updated Feb. 14, 2017, 4:27 a.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

> On Feb. 14, 2017, 3:48 a.m., Mehrdad Nurolahzade wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1135 > > > > > > We are skipping task delete through

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/ --- (Updated Feb. 14, 2017, 4:12 a.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165434 ---

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165428 --- Master (40d91fe) is red with this patch.

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

> On Feb. 14, 2017, 1:54 a.m., Reza Motamedi wrote: > > LGTM! > > > > But, should we test this in the test cluster? At least to check the effect > > of _limit_? I did test this in Vagrant. All the options work correctly. - David ---

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/ --- (Updated Feb. 14, 2017, 2:01 a.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165425 --- LGTM! But, should we test this in the test cluster? At least to

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165421 --- Master (40d91fe) is red with this patch.

Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/ --- Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer