Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/ --- (Updated March 2, 2017, 1:12 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

> On March 1, 2017, 11:50 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 179-192 (original), 196-209 (patched) > > > > > > This compaction reads like it

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review167565 --- Some further thoughts (not completed)

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

> On Feb. 22, 2017, 3:31 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > > Lines 210-228 (patched) > > > > > > This reads like as if there is a more general concept

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

> On Feb. 23, 2017, 12:31 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > > Lines 210-228 (patched) > > > > > > This reads like as if there is a more general concept

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review167149 --- Master (2652fe0) is red with this patch.

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/ --- (Updated Feb. 28, 2017, 9:25 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review166769 --- Master (98eb99a) is red with this patch.

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/ --- (Updated Feb. 24, 2017, 10:47 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote: > > How does this work with preemption? Should we reject a configuration where > > tasks can be preempted and reserve resources? First pass is not to preempt at all for tasks needing a dynamic reservation. Will do a followup patch for that.

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review166752 --- How does this work with preemption? Should we reject a

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review166620 --- Master (98eb99a) is red with this patch.

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/ --- (Updated Feb. 24, 2017, 12:28 a.m.) Review request for Aurora, Mehrdad

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java, > > lines 99-100 > > > > > > To short-circuit both loops this should probably be a

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review166430 --- This is only a very partial review. My brain was not capable of

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review165623 --- Master (9ea8979) is red with this patch.

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review165608 --- This patch does not apply cleanly against master (0e9c086), do

Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/ --- Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.