Re: Review Request 56935: Fix for unnecessary object serializations

2017-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/#review173414 --- Master (c85bffd) is green with this patch. ./build-support/jenki

Re: Review Request 56935: Fix for unnecessary object serializations

2017-04-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/ --- (Updated April 28, 2017, 3:15 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 56935: Fix for unnecessary object serializations

2017-04-19 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/#review172352 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Feb. 22, 20

Re: Review Request 56935: Fix for unnecessary object serializations

2017-04-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/#review172213 --- Ship it! LGTM. We should ship it before it gets stale :-) - St

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/ --- (Updated Feb. 22, 2017, 11:34 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
> On Feb. 22, 2017, 10:27 a.m., Zameer Manji wrote: > > Could you please add to the RB description on what methodology you used to > > determine this and what are the results of this patch? > > > > > > Further, do you have any ideas on how we can prevent regressions? Short-term, we need to in

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
> On Feb. 22, 2017, 10:07 a.m., Reza Motamedi wrote: > > Mehrdad, do you also have some stats on how much these changes reduced the > > object creation rate? The object allocation rate dropped from of 25 M/s on average to 15-20 M/s. But, as I indicated above these numbers are not representativ

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/#review166387 --- Could you please add to the RB description on what methodology you

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/#review166385 --- Mehrdad, do you also have some stats on how much these changes red

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/#review166380 --- Ship it! Master (98eb99a) is green with this patch. ./build-s

Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Repository: auror