Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review188623 --- Ship it! Master (c638877) is green with this patch. ./build-s

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread Bill Farner
> On Oct. 18, 2017, 2:48 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/HostOffer.java > > Lines 44-47 (patched) > > > > > > Please extend this comment a bit and indicate that this checks for t

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review188593 --- Master (ff39120) is red with this patch. ./build-support/jenkins

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread David McLaughlin
> On Oct. 18, 2017, 9:48 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/HostOffer.java > > Lines 62-66 (patched) > > > > > > I have had a short peek at our clusters and the number of offers >

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review188586 --- Ship it! src/main/java/org/apache/aurora/scheduler/HostOffer.j

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review188589 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 18, 20

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review188588 --- Ship it! Ship It! - Jordan Ly On Oct. 18, 2017, 9:25 p.m., B

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review188585 --- Ship it! Ship It! - David McLaughlin On Oct. 18, 2017, 9:25

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread David McLaughlin
> On Oct. 18, 2017, 9:29 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/HostOffer.java > > Lines 64-65 (patched) > > > > > > Shouldn't this be or (||)? Oh, derp, nm. I read it backwards :

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread Stephan Erb
> On Oct. 13, 2017, 10:12 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 220-224 (patched) > > > > > > This won't work for us. > > > > We are using

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review188582 --- src/main/java/org/apache/aurora/scheduler/HostOffer.java Lines 64

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

2017-10-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/ --- (Updated Oct. 18, 2017, 2:25 p.m.) Review request for Aurora, David McLaughlin