Re: Review Request 63092: Detect and parse Thermos config in Diff output

2017-10-18 Thread David McLaughlin
> On Oct. 18, 2017, 5:14 p.m., Santhosh Kumar Shanmugham wrote: > > Can we pretty-print the configs? (Removing all the escaped quotes and all) The only quotes left will be in strings (like cmdline) that contain other quoted strings. - David

Re: Review Request 63092: Detect and parse Thermos config in Diff output

2017-10-18 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/#review188521 --- Ship it! Can we pretty-print the configs? (Removing all the

Re: Review Request 63092: Detect and parse Thermos config in Diff output

2017-10-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/#review188427 --- Ship it! Master (0efe415) is green with this patch.

Re: Review Request 63092: Detect and parse Thermos config in Diff output

2017-10-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ --- (Updated Oct. 18, 2017, 12:16 a.m.) Review request for Aurora, Kai Huang,

Re: Review Request 63092: Detect and parse Thermos config in Diff output

2017-10-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ --- (Updated Oct. 18, 2017, 12:08 a.m.) Review request for Aurora, Kai Huang,

Re: Review Request 63092: Detect and parse Thermos config in Diff output

2017-10-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ --- (Updated Oct. 17, 2017, 11:19 p.m.) Review request for Aurora, Kai Huang,

Re: Review Request 63092: Detect and parse Thermos config in Diff output

2017-10-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/#review188411 --- Ship it! Master (0efe415) is green with this patch.

Review Request 63092: Detect and parse Thermos config in Diff output

2017-10-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description