Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review204325 --- Master (34be631) is green with this patch. ./build-support/jenki

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated June 5, 2018, 8:58 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review204308 --- Ship it! Ship It! - David McLaughlin On June 5, 2018, 3:35 a

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review204305 --- Master (34be631) is green with this patch. ./build-support/jenki

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

> On June 1, 2018, 1:44 p.m., David McLaughlin wrote: > > Looks great! > > > > Has this been load-tested? Do we know how many concurrent machines with > > coordinator tasks can be put into maintenance before it starts to affect > > offer processing, etc.? > > Santhosh Kumar Shanmugham wrote:

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated June 4, 2018, 8:35 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

> On June 4, 2018, 12:24 p.m., Renan DelValle wrote: > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > > Lines 396 (patched) > > > > > > Should we make 20 a constant for thi

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated June 4, 2018, 8:17 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

> On June 1, 2018, 1:44 p.m., David McLaughlin wrote: > > Looks great! > > > > Has this been load-tested? Do we know how many concurrent machines with > > coordinator tasks can be put into maintenance before it starts to affect > > offer processing, etc.? Load testing results show that there

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review204272 --- Ship it! Ship It! src/test/java/org/apache/aurora/scheduler/c

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review204202 --- Looks great! Has this been load-tested? Do we know how many conc

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203930 --- Master (34be631) is green with this patch. ./build-support/jenki

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 25, 2018, 6:13 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203924 --- Master (34be631) is red with this patch. ./build-support/jenkins

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203916 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 25, 2018, 3

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203913 --- Master (34be631) is red with this patch. ./build-support/jenkins

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 25, 2018, 3:15 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203908 --- Master (34be631) is red with this patch. ./build-support/jenkins

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

> On May 25, 2018, 8:50 a.m., Stephan Erb wrote: > > LGTM! Especially thanks for the thorough documentation. > > > > I have just a bunch of questions below. Feel free to address those as you > > see fit. I am away for the next few days I don't want to block the patch > > any further. Thanks f

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

> On May 25, 2018, 11:40 a.m., Jordan Ly wrote: > > docs/operations/configuration.md > > Lines 315-316 (original), 315-316 (patched) > > > > > > nit: why double dashes? Scheduler params use single `-` while the Exe

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 25, 2018, 2:14 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203896 --- Ship it! Awesome work! Very excited for this new feature. doc

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203807 --- Ship it! LGTM! Especially thanks for the thorough documentation

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203836 --- Master (34be631) is green with this patch. ./build-support/jenki

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 24, 2018, 5:24 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 24, 2018, 11:57 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203753 --- Ship it! Master (34be631) is green with this patch. ./build-s

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 23, 2018, 11:24 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

> On May 23, 2018, 4:13 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java > > Lines 236 (patched) > > > > > > I think listing the unaffected tasks might be a bit gratuitious. I

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203701 --- Great documentation and tests! Looks pretty much ready to go from

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203629 --- src/test/sh/org/apache/aurora/e2e/sla_policy.aurora Lines 15 (pat

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203627 --- Ship it! Master (34be631) is green with this patch. ./build-s

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203624 --- Note to reviewers: Since the rebase removes changes that were part

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 22, 2018, 5:21 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203396 --- Master (805a53f) is red with this patch. ./build-support/jenkins

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

> On May 16, 2018, 2:35 p.m., Stephan Erb wrote: > > I have done a first quick pass. I will have a second closer look once the > > storage patch has landed. Thanks for the review. Much appreciated. > On May 16, 2018, 2:35 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 17, 2018, 7:49 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203276 --- I have done a first quick pass. I will have a second closer look o

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203153 --- Master (805a53f) is red with this patch. ./build-support/jenkins

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203150 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 15, 2018, 1

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203149 --- Master (805a53f) is red with this patch. ./build-support/jenkins

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 15, 2018, 10:16 a.m.) Review request for Aurora, David McLaughlin,