Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- (Updated March 25, 2014, 2:55 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38401 --- Ship it! src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-24 Thread Suman Karumuri
> On March 24, 2014, 6:35 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 225 > > > > > > This method makes for difficult-to-read call-sites. How about > > silent=

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38390 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 7:06 p.m.,

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/ --- (Updated March 24, 2014, 7:21 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38387 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38381 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-24 Thread Mark Chu-Carroll
> On March 21, 2014, 5:06 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 283 > > > > > > No, it shouldn't. It's a call to the global function declared towards > > the top

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38379 --- ping? - Mark Chu-Carroll On March 21, 2014, 2:58 p.m., Mark Chu-C

Re: Review Request 17056: fix dependencies for setup_py

2014-03-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated March 24, 2014, 10:16 p.m.) Review request for Aurora and Kevin Sweene

Re: Review Request 17056: fix dependencies for setup_py

2014-03-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38378 --- crap, i missed this. will merge/repost/submit. - Brian Wickman O

Re: Review Request 17056: fix dependencies for setup_py

2014-03-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38377 --- crap, i missed this. will merge/repost/submit. - Brian Wickman O

Re: Review Request 17042: Add a web interface to the zookeeper instance.

2014-03-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17042/#review38366 --- Ship it! Ship It! - Kevin Sweeney On Feb. 9, 2014, 10:40 p.m., T

Re: Review Request 17056: fix dependencies for setup_py

2014-03-24 Thread Bill Farner
> On March 21, 2014, 3:07 p.m., Bill Farner wrote: > > Update or discard? Ping? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38108 -

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 24, 2014, 8:47 p.m.) Review request for Aurora, Kevin Sweeney, M

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-24 Thread Suman Karumuri
> On March 21, 2014, 11:53 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/cli/test_quota.py, line 47 > > > > > > > Currently, the mocked calls can't detect renamed and missing thrift > > structs. > >

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38338 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 24, 2014, 2:58 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38336 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/#review38325 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java <