Re: Review Request 19709: CrontabEntry parser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 27, 2014, 6:02 p.m.) Review request for Aurora, Maxim Khutornenk

Review Request 19767: CronScheduler based on Quartz

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19767/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-132

Re: Review Request 19709: CrontabEntry parser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 27, 2014, 5:48 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19709: CrontabEntry parser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 27, 2014, 5:46 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19709: CrontabEntry parser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38857 --- Ship it! src/main/resources/org/apache/aurora/scheduler/cron/testi

Re: Review Request 19648: Preserving sandbox deleted task history.

> On March 27, 2014, 7:09 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line > > 107 > > > > > > Would it take much to make this private? It would be nice if noth

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/ --- (Updated March 28, 2014, 12:27 a.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 19709: CrontabEntry parser

> On March 27, 2014, 9:44 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java, line 148 > > > > > > Do these all need to be public? Looks like most of these accessors are > >

Re: Review Request 19709: CrontabEntry parser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 27, 2014, 5:14 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19709: CrontabEntry parser

> On March 27, 2014, 2:44 p.m., Bill Farner wrote: > > build.gradle, line 377 > > > > > > What would it take to do that now? Is it as simple as > > System.setProperty? Dropped. > On March 27, 2014, 2:44 p.m., Bill

Re: Review Request 19709: CrontabEntry parser

> On March 27, 2014, 2:54 p.m., Bill Farner wrote: > > build.gradle, line 223 > > > > > > Please exclude junit-dep instead. Done. - Kevin --- This is an auto

Re: Review Request 19727: AURORA-278: Review Incubator release check list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19727/#review38847 --- Ship it! Ship It! - Bill Farner On March 27, 2014, 3:24 p.m., Ja

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/#review38844 --- Ship it! Ship It! - Bill Farner On March 27, 2014, 7:59 p.m., Ma

Re: Review Request 19648: Preserving sandbox deleted task history.

> On March 27, 2014, 7:09 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line > > 107 > > > > > > Would it take much to make this private? It would be nice if noth

Review Request 19756: Filtering safe domain results by hosts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-295 https://issue

Re: Review Request 19565: Role and Role/env pages for Scheduler

> On March 26, 2014, 5:27 p.m., Bill Farner wrote: > > I tried this out locally, and the browser back button appears to be broken > > when i click on a role, then a job. Does this repro for you? > > > > Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource > > Consumption]

Re: Review Request 19565: Role and Role/env pages for Scheduler

> On March 26, 2014, 11:46 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line > > 52 > > > > > > Same story as before, why not just use one field if they follow e

Re: Review Request 19709: CrontabEntry parser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38821 --- build.gradle

Re: Review Request 19709: CrontabEntry parser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 27, 2014, 2:52 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19709: CrontabEntry parser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38799 --- build.gradle

Re: Review Request 19648: Preserving sandbox deleted task history.

> On March 27, 2014, 8:26 p.m., Suman Karumuri wrote: > > Can this wait till the UI changes are pushed (in the next few days) > > Maxim Khutornenko wrote: > I am not sure why this work change would have to be blocked by the UI > refactoring. It has a very limited UI component in it and I wo

Re: Review Request 19565: Role and Role/env pages for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- (Updated March 27, 2014, 9:04 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 19565: Role and Role/env pages for Scheduler

> On March 26, 2014, 11:46 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line > > 65 > > > > > > Are there specific browsers we're stretching for compatibility wi

Re: Review Request 17750: CronScheduler implementation based on Quartz.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17750/#review38805 --- This is obsoleted by https://reviews.apache.org/r/17750/ so I'm disc

Re: Review Request 19565: Role and Role/env pages for Scheduler

> On March 26, 2014, 5:27 p.m., Bill Farner wrote: > > I tried this out locally, and the browser back button appears to be broken > > when i click on a role, then a job. Does this repro for you? > > > > Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource > > Consumption]

Re: Review Request 19648: Preserving sandbox deleted task history.

> On March 27, 2014, 8:26 p.m., Suman Karumuri wrote: > > Can this wait till the UI changes are pushed (in the next few days) I am not sure why this work change would have to be blocked by the UI refactoring. It has a very limited UI component in it and I would rather ship it sooner to get bet

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/#review38800 --- Can this wait till the UI changes are pushed (in the next few days)

Re: Review Request 19648: Preserving sandbox deleted task history.

> On March 27, 2014, 7:09 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line > > 107 > > > > > > Would it take much to make this private? It would be nice if noth

Re: Review Request 19648: Preserving sandbox deleted task history.

> On March 27, 2014, 7:09 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line > > 107 > > > > > > Would it take much to make this private? It would be nice if noth

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/ --- (Updated March 27, 2014, 7:59 p.m.) Review request for Aurora, Kevin Sweeney, S

Re: Review Request 19648: Preserving sandbox deleted task history.

> On March 27, 2014, 7:09 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 232 > > > > > > Both callers immediately call get() on the result. Seems sane with the > > signat

Re: Review Request 19710: AURORA-78: automate and enforce release workflow

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19710/#review38793 --- build-support/release/release-candidate

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/#review38779 --- src/main/java/org/apache/aurora/scheduler/base/Tasks.java

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 27, 2014, 7:06 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 27, 2014, 6:57 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

> On March 26, 2014, 11:52 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/cli/quota.py, line 70 > > > > > > DRY: > > > > quota_result = resp.result.getQuotaResult > > > > apply libar

Re: Review Request 19431: Add instance specifier syntax to clientv2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38788 --- Ship it! Ship It! - Brian Wickman On March 26, 2014, 6:08 p.m.,

Re: Review Request 19550: Filtering out non-prod tasks for domain sla calculations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19550/#review38787 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 9:15 p.m.,

Re: Review Request 19431: Add instance specifier syntax to clientv2

Bill: It's been 24 hours, and I'm still waiting on a clarification request. Please, can you take a minute, and answer, so that I can get this review done? -Mark On Wed, Mar 26, 2014 at 3:28 PM, Mark Chu-Carroll < mchucarr...@twopensource.com> wrote: >This is an automatically generated e

Re: Review Request 19550: Filtering out non-prod tasks for domain sla calculations.

> On March 25, 2014, 11:15 p.m., Maxim Khutornenko wrote: > > Ping, Brian. Ping again. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19550/#review38555 -

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/#review38750 --- src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java <

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/ --- (Updated March 27, 2014, 6:09 p.m.) Review request for Aurora, Kevin Sweeney, S

Re: Review Request 19710: AURORA-78: automate and enforce release workflow

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19710/#review38758 --- build-support/release/changelog

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/#review38682 --- Just realized RB failed to publish this last night :-/ Feel free to

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/ --- (Updated March 27, 2014, 4:06 p.m.) Review request for Aurora, Kevin Sweeney, S

Re: Review Request 19648: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19648/ --- (Updated March 27, 2014, 4:06 p.m.) Review request for Aurora, Kevin Sweeney, S

Review Request 19727: AURORA-278: Review Incubator release check list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19727/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: A

Re: Review Request 19462: [AURORA-282] add gradle target distDeb

> On March 20, 2014, 4:19 p.m., Jake Farrell wrote: > > build.gradle, line 375 > > > > > > shouldnt this be in /usr/local/lib Seams that usage is that native package files are in /usr/lib/ and non native (tar pip ...

Re: Review Request 19462: [AURORA-282] add gradle target distDeb

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19462/ --- (Updated March 27, 2014, 1:23 p.m.) Review request for Aurora and Jake Farrell.