Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20650/#review41272 --- build.gradle https://reviews.apache.org/r/20650/#comment74713

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review41273 --- Ship it! +1 - Suman Karumuri On April 24, 2014, 4:22 a.m., Bill

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Jake Farrell
On April 24, 2014, 6:36 a.m., Suman Karumuri wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 Can we add dist/ to this list? +1 with dist added - Jake --- This is an

Re: Review Request 19627: Updates documentation files for markdown consistency

2014-04-24 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19627/#review41296 --- Ship it! Thanks for tackling this Dave, looks good for doc - site

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41299 --- Dan has a review up for testing the version of python in use for

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41304 --- This is on master now. - Maxim Khutornenko On April 24, 2014,

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20650/#review41307 --- build.gradle https://reviews.apache.org/r/20650/#comment74729

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Brian Wickman
On April 24, 2014, 1:37 p.m., Jake Farrell wrote: Dan has a review up for testing the version of python in use for development, do we want to pull 2.6 out of that check list if we are seeing these errors from stdlib caused in that version? no, don't worry about it. the latest pex sync

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41330 --- e2e results: Built pants-0.0.21.pex Build operating on targets:

Re: Review Request 20490: Add a get version API method.

2014-04-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20490/#review41335 --- if this merges to master after r/20583, you will need to kill the

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41331 --- e2e results: Built pants-0.0.21.pex Build operating on targets:

Re: Review Request 20394: Add return code to task/process pages

2014-04-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/#review41336 --- Ship it! in the future it's customary to attach screenshots for UI

Re: Review Request 20490: Add a get version API method.

2014-04-24 Thread Brian Wickman
Make sure to close the reviewboard, otherwise it will continue to show up in review dashboards. On Thu, Apr 24, 2014 at 10:20 AM, Mark Chu-Carroll mchucarr...@apache.orgwrote: It's already pushed. On Thu, Apr 24, 2014 at 1:16 PM, Brian Wickman wick...@apache.org wrote: This is an

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41337 --- Ship it! Ship It! - Bill Farner On April 24, 2014, 1:33 a.m.,

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Bill Farner
On April 24, 2014, 3:06 p.m., Maxim Khutornenko wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 +1. This should work just fine: excludeDirs = [file($buildDir)] Replied in thread above. - Bill

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Maxim Khutornenko
On April 24, 2014, 3:06 p.m., Maxim Khutornenko wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 +1. This should work just fine: excludeDirs = [file($buildDir)] Bill Farner wrote: Replied in thread above. Is it

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41345 --- Ship it! Ship It! - Jake Farrell On April 24, 2014, 1:33 a.m.,

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Bill Farner
On April 24, 2014, 6:36 a.m., Suman Karumuri wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 Can we add dist/ to this list? Jake Farrell wrote: +1 with dist added Bill Farner wrote: You cannot exclude dist/,

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Maxim Khutornenko
On April 24, 2014, 6:36 a.m., Suman Karumuri wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 Can we add dist/ to this list? Jake Farrell wrote: +1 with dist added Bill Farner wrote: You cannot exclude dist/,

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Jake Farrell
On April 24, 2014, 6:36 a.m., Suman Karumuri wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 Can we add dist/ to this list? Jake Farrell wrote: +1 with dist added Bill Farner wrote: You cannot exclude dist/,

Re: Review Request 20620: Add machine maintainer auth capability.

2014-04-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20620/#review41356 --- Ship it! Ship It! - Maxim Khutornenko On April 23, 2014, 7:39

Review Request 20678: Remove unused mootools dependency

2014-04-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20678/ --- Review request for Aurora, Jake Farrell and Brian Wickman. Bugs: AURORA-147

Re: Review Request 20678: Remove unused mootools dependency

2014-04-24 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20678/#review41365 --- Ship it! Ship It! - Jake Farrell On April 24, 2014, 6:46 p.m.,

Re: Review Request 20678: Remove unused mootools dependency

2014-04-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20678/#review41368 --- Ship it! Ship It! - Brian Wickman On April 24, 2014, 6:46 p.m.,

Review Request 20682: Adding my gpg key.

2014-04-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20682/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 20682: Adding my gpg key.

2014-04-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20682/ --- (Updated April 24, 2014, 9:19 p.m.) Review request for Aurora and Kevin

Re: Review Request 20682: Adding my gpg key.

2014-04-24 Thread Suman Karumuri
On April 24, 2014, 7 p.m., Jake Farrell wrote: KEYS, line 299 https://reviews.apache.org/r/20682/diff/1/?file=567973#file567973line299 Missing signature header for key gpg --list-sigs ... Added. - Suman ---

Re: Review Request 20682: Adding my gpg key.

2014-04-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20682/#review41390 --- Ship it! Ship It! - Kevin Sweeney On April 24, 2014, 2:19 p.m.,

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41384 --- Should the documentation for this feature be part of this review?

Re: Review Request 20689: Fixing broken HistoryPruner

2014-04-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20689/#review41409 --- Ship it!

Re: Review Request 20689: Fixing broken HistoryPruner

2014-04-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20689/ --- (Updated April 24, 2014, 10:45 p.m.) Review request for Aurora and Bill

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41420 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 24, 2014, 8:17 p.m.) Review request for Aurora, David

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20650/#review41432 --- Ship it! Ship It! - Maxim Khutornenko On April 24, 2014, 5:05

Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt

2014-04-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/#review41435 --- I have some reservations with this, but they're not well-formed. I

Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown

2014-04-24 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20027/#review41436 --- Ship it! Ship It! - Jake Farrell On April 9, 2014, 2:31 a.m.,

Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown

2014-04-24 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20027/ --- (Updated April 25, 2014, 4:21 a.m.) Review request for Aurora, Jake Farrell

Re: Review Request 20469: AURORA-178 - Log snapshot operations

2014-04-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20469/#review41437 --- Dave - can you address Maxim's comment? I assume he will commit at