Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 29, 2014, 10:27 a.m.) Review request for Aurora, David

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 29, 2014, 12:47 p.m.) Review request for Aurora, David

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-29 Thread Suman Karumuri
On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way.

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-29 Thread Bill Farner
On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way.

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-29 Thread Maxim Khutornenko
On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way.

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-29 Thread Kevin Sweeney
On April 28, 2014, 4 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way.

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-29 Thread Jake Farrell
On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way.

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 29, 2014, 3:01 p.m.) Review request for Aurora, David

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-29 Thread Bill Farner
On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way.

Re: Review Request 20808: Adding unhandled error logging into AsyncModule.

2014-04-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20808/#review41768 --- src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java

Re: Review Request 20824: AURORA-278: Review Incubator release check list - missing license headers

2014-04-29 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20824/ --- (Updated April 29, 2014, 8:51 p.m.) Review request for Aurora and Kevin

Re: Review Request 20824: AURORA-278: Review Incubator release check list - missing license headers

2014-04-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20824/#review41774 --- Ship it! Ship It! - Kevin Sweeney On April 29, 2014, 1:51 p.m.,

Re: Review Request 20808: Adding unhandled error logging into AsyncModule.

2014-04-29 Thread Maxim Khutornenko
On April 29, 2014, 8:04 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 48 https://reviews.apache.org/r/20808/diff/1/?file=569885#file569885line48 Nice! To really polish this off, you could accept a Logger to prove the bug fix in a

Re: Review Request 20808: Adding unhandled error logging into AsyncModule.

2014-04-29 Thread Bill Farner
On April 29, 2014, 8:04 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 48 https://reviews.apache.org/r/20808/diff/1/?file=569885#file569885line48 Nice! To really polish this off, you could accept a Logger to prove the bug fix in a

Re: Review Request 20808: Adding unhandled error logging into AsyncModule.

2014-04-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20808/#review41784 --- Ship it!

Review Request 20867: Upgrade to pants==23

2014-04-29 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20867/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-368

Re: Review Request 20867: Upgrade to pants==23

2014-04-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20867/#review41788 --- Ship it! Ship It! - Kevin Sweeney On April 29, 2014, 4:46 p.m.,