Review Request 22747: Add a python clean.sh script

2014-06-18 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22747/ --- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Repository: auro

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Maxim Khutornenko
> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Mark Chu-Carroll
> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Maxim Khutornenko
> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Mark Chu-Carroll
> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Review Request 22746: Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.

2014-06-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22746/ --- Review request for Aurora, David McLaughlin and Mark Chu-Carroll. Bugs: AURORA-

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Maxim Khutornenko
> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Mark Chu-Carroll
> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Maxim Khutornenko
> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Mark Chu-Carroll
> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Maxim Khutornenko
> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Maxim Khutornenko
> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 18, 2014, 10:59 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Mark Chu-Carroll
> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

2014-06-18 Thread Mark Chu-Carroll
> On June 16, 2014, 5:25 p.m., David McLaughlin wrote: > > src/main/python/apache/aurora/client/cli/json_tree_diff.py, line 56 > > > > > > Not a big deal given how rare it would occur, but you're using a > > delimiter