Re: Review Request 22747: Add a python clean.sh script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22747/#review46351 --- Ship it! Ship It! - Brian Wickman On June 20, 2014, 6:07 p.m., J

Re: Review Request 22849: clientv2 package should point to config-packaged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22849/#review46348 --- Ship it! Ship It! - Maxim Khutornenko On June 20, 2014, 11:53 p.

Review Request 22849: clientv2 package should point to config-packaged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22849/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.

> On June 20, 2014, 5:16 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/api/sla.py, line 315 > > > > > > This seems comment-worthy to hopefully avoid being bitten again. Done. - Maxim --

Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22746/ --- (Updated June 20, 2014, 11:09 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22839: Add configuration plugins to default aurora client.

> On June 20, 2014, 5:30 p.m., Brian Wickman wrote: > > not a big fan of globals here. can you instead annotate the context with > > the exception and in post-dispatch have the plugin print it out if > > --reveal-errors is set? > > Mark Chu-Carroll wrote: > I'm not a big fan of globals ei

Re: Review Request 22701: Adding admin command to get locks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22701/ --- (Updated June 20, 2014, 9:55 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22701: Adding admin command to get locks.

> On June 20, 2014, 5:20 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/commands/test_admin.py, line 210 > > > > > > How about a constant instead? Done. > On June 20, 2014, 5:20 p.m., Bill Farner

Re: Review Request 22839: Add configuration plugins to default aurora client.

> On June 20, 2014, 9:30 p.m., Brian Wickman wrote: > > not a big fan of globals here. can you instead annotate the context with > > the exception and in post-dispatch have the plugin print it out if > > --reveal-errors is set? > > Mark Chu-Carroll wrote: > I'm not a big fan of globals ei

Re: Review Request 22839: Add configuration plugins to default aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46337 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 22839: Add configuration plugins to default aurora client.

> On June 20, 2014, 5:30 p.m., Brian Wickman wrote: > > not a big fan of globals here. can you instead annotate the context with > > the exception and in post-dispatch have the plugin print it out if > > --reveal-errors is set? > > Mark Chu-Carroll wrote: > I'm not a big fan of globals ei

Re: Review Request 22839: Add configuration plugins to default aurora client.

> On June 20, 2014, 9:30 p.m., Brian Wickman wrote: > > not a big fan of globals here. can you instead annotate the context with > > the exception and in post-dispatch have the plugin print it out if > > --reveal-errors is set? > > Mark Chu-Carroll wrote: > I'm not a big fan of globals ei

Re: Review Request 22839: Add configuration plugins to default aurora client.

> On June 20, 2014, 9:30 p.m., Brian Wickman wrote: > > not a big fan of globals here. can you instead annotate the context with > > the exception and in post-dispatch have the plugin print it out if > > --reveal-errors is set? > > Mark Chu-Carroll wrote: > I'm not a big fan of globals ei

Re: Review Request 22839: Add configuration plugins to default aurora client.

> On June 20, 2014, 5:30 p.m., Brian Wickman wrote: > > not a big fan of globals here. can you instead annotate the context with > > the exception and in post-dispatch have the plugin print it out if > > --reveal-errors is set? I'm not a big fan of globals either, but I'm concerned about depe

Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- Review request for Aurora, David McLaughlin and Joe Smith. Bugs: AURORA-542

Re: Review Request 22839: Add configuration plugins to default aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46325 --- not a big fan of globals here. can you instead annotate the context

Re: Review Request 22839: Add configuration plugins to default aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46323 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Review Request 22839: Add configuration plugins to default aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/ --- Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: aurora-544

Re: Review Request 22701: Adding admin command to get locks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22701/#review46311 --- Ship it! Ship It! - Mark Chu-Carroll On June 17, 2014, 7:25 p.m.

Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22746/#review46310 --- Ship it! Ship It! - Mark Chu-Carroll On June 18, 2014, 2:17 p.m.

Re: Review Request 22747: Add a python clean.sh script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22747/#review46309 --- Ship it! Ship It! - Mark Chu-Carroll On June 20, 2014, 2:07 p.m.

Re: Review Request 22790: Adding a getTasksStatusLight RPC to return null ExecutorConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22790/#review46300 --- Ship it! Going to ship this because I know there's no great solutio

Re: Review Request 22701: Adding admin command to get locks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22701/#review46299 --- Ship it! Ship It! - David McLaughlin On June 17, 2014, 11:25 p.m

Re: Review Request 22747: Add a python clean.sh script

> On June 19, 2014, 11:23 a.m., Kevin Sweeney wrote: > > build-support/python/clean.sh, line 1 > > > > > > set -ux? good call. > On June 19, 2014, 11:23 a.m., Kevin Sweeney wrote: > > build-support/python/clean.sh, li

Re: Review Request 22747: Add a python clean.sh script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22747/ --- (Updated June 20, 2014, 11:07 a.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 22747: Add a python clean.sh script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22747/ --- (Updated June 20, 2014, 11:07 a.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 22747: Add a python clean.sh script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22747/ --- (Updated June 20, 2014, 11:05 a.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 22701: Adding admin command to get locks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22701/#review46291 --- Ship it! src/test/python/apache/aurora/client/commands/test_admin.

Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22746/#review46290 --- Ship it! src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 22701: Adding admin command to get locks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22701/#review46274 --- Ping. - Maxim Khutornenko On June 17, 2014, 11:25 p.m., Maxim Khu

Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22746/#review46275 --- Ping. - Maxim Khutornenko On June 18, 2014, 6:17 p.m., Maxim Khut

Re: Review Request 22697: Documenting SLA stats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22697/#review46273 --- Anyone? - Maxim Khutornenko On June 17, 2014, 9:14 p.m., Maxim Kh