Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

2015-02-18 Thread Moses Nakamura
> On Feb. 18, 2015, 7 p.m., Stephan Erb wrote: > > For this change to be useful, we also have to think about the meaning of > > `initial_interval_secs`. In its curent form, health checks only start when > > the initial delay has passed. Commonly this delay has to be set very high > > in order

Re: Review Request 31176: Split out ReadOnlySchedulerImplTest.

2015-02-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31176/#review73072 --- Master (e0e3f2e) is red with this patch. ./build-support/jenkins/b

Review Request 31176: Split out ReadOnlySchedulerImplTest.

2015-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31176/ --- Review request for Aurora. Repository: aurora Description --- Split out

Re: Review Request 31171: Saving backups asynchronously.

2015-02-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73064 --- src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBac

Re: Review Request 31171: Saving backups asynchronously.

2015-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73055 --- Ship it! Ship It! - Kevin Sweeney On Feb. 18, 2015, 4:27 p.m., M

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

2015-02-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31170/#review73050 --- src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateSto

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

2015-02-18 Thread Craig Wickesser
> On Feb. 18, 2015, 7:34 p.m., Zameer Manji wrote: > > Thanks for your contribution. Would you mind adding myself (zmanji) and > > Kevin Sweeny (kevints) to the People line of the review? Thanks, and done. - Craig --- This is an automa

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

2015-02-18 Thread Bill Farner
> On Feb. 19, 2015, 12:52 a.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift, line 83 > > > > > > Do we really need a deprecation cycle here given the beta status of the > > upd

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

2015-02-18 Thread Craig Wickesser
> On Feb. 18, 2015, 7:42 p.m., Kevin Sweeney wrote: > > Hi Craig, thanks for the contribution. I'm wondering if this document might > > be better suited as a gist or blog post given that it's dated (0.7.1) and > > we don't have automated test coverage to ensure it doesn't diverge from the > >

Re: Review Request 31171: Saving backups asynchronously.

2015-02-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73044 --- Ship it! Master (e0e3f2e) is green with this patch. ./build-suppo

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

2015-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31170/#review73043 --- api/src/main/thrift/org/apache/aurora/gen/storage.thrift

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

2015-02-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31170/#review73038 --- src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.ja

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

2015-02-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31170/#review73042 --- Ship it! Master (e0e3f2e) is green with this patch. ./build-suppo

Review Request 31171: Saving backups asynchronously.

2015-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-1108

Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

2015-02-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31170/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-109

Re: Review Request 31165: Add lifecycle endpoints to Thermos Observer

2015-02-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31165/#review73034 --- Master (e0e3f2e) is red with this patch. ./build-support/jenkins/b

Review Request 31165: Add lifecycle endpoints to Thermos Observer

2015-02-18 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31165/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-1132 https://issu

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

2015-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31042/#review72994 --- Hi Craig, thanks for the contribution. I'm wondering if this documen

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

2015-02-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31042/#review72991 --- Thanks for your contribution. Would you mind adding myself (zmanji)

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

2015-02-18 Thread Zameer Manji
> On Feb. 14, 2015, 11:39 a.m., Florian Pfeiffer wrote: > > docs/build-for-centos.md, line 40 > > > > > > Installing gradle is probably not needed, since the gradle wrapper is > > included in the aurora project? > > Z

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

2015-02-18 Thread Zameer Manji
> On Feb. 14, 2015, 11:39 a.m., Florian Pfeiffer wrote: > > docs/build-for-centos.md, line 40 > > > > > > Installing gradle is probably not needed, since the gradle wrapper is > > included in the aurora project? The g

Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

2015-02-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31104/#review72980 --- For this change to be useful, we also have to think about the meanin