Re: Review Request 31570: Suppressing duplicate update instance events.

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31570/#review76025 --- Master (b53e023) is red with this patch.

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Bill Farner
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 48 https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48 Do we really want to fail an operation when a message gets too long?

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Maxim Khutornenko
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 48 https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48 Do we really want to fail an operation when a message gets too long?

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

2015-03-10 Thread Maxim Khutornenko
On March 7, 2015, 5:30 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java, line 326 https://reviews.apache.org/r/31821/diff/1/?file=888148#file888148line326 Not yours, but it seems odd that we would call a function and

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31821/#review75901 --- Ship it! Master (1b1931c) is green with this patch.

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869/ --- (Updated March 10, 2015, 5:44 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31901: Export task status reason counters whenever they are present.

2015-03-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31901/ --- (Updated March 10, 2015, 6 p.m.) Review request for Aurora and Maxim

Review Request 31901: Export task status reason counters whenever they are present.

2015-03-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31901/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 11, 2015, 2:53 a.m.) Review request for Aurora and Maxim

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/#review76022 --- Ship it! Master (b53e023) is green with this patch.

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76037 --- Ship it! Master (eb392b3) is green with this patch.

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 12:45 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869/#review75929 --- Ship it! Master (48dc4c7) is green with this patch.

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Kevin Sweeney
On March 10, 2015, 11:48 a.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, lines 59-62 https://reviews.apache.org/r/31820/diff/3/?file=889978#file889978line59 Maybe move this to the ticket and kill the commented out code

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75959 --- Ship it! Master (48dc4c7) is green with this patch.

Re: Review Request 31901: Export task status reason counters whenever they are present.

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31901/#review75923 --- Ship it! Master (48dc4c7) is green with this patch.

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75954 --- Ship it! Ship It! - Bill Farner On March 10, 2015, 7:45 p.m.,

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review75989 --- Ship it! Master (48dc4c7) is green with this patch.

Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181

Re: Review Request 31901: Export task status reason counters whenever they are present.

2015-03-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31901/#review75994 --- Ship it! Ship It! - Maxim Khutornenko On March 10, 2015, 6

Review Request 31918: Improve response logging in TRequestsTransport

2015-03-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31918/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review75997 --- src/main/python/apache/aurora/client/base.py

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869/#review75980 --- src/main/python/apache/aurora/client/api/__init__.py

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Bill Farner
On March 11, 2015, 12:08 a.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 282 https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282 My understanding was that zmanji was attempting to remove AuroraCommandContext and patch

Re: Review Request 31918: Improve response logging in TRequestsTransport

2015-03-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31918/#review76002 --- Ship it! Ship It! - Zameer Manji On March 10, 2015, 5:05 p.m.,

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/#review76004 --- Ship it! Ship It! - David McLaughlin On March 11, 2015, 12:04

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Zameer Manji
On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 282 https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282 My understanding was that zmanji was attempting to remove AuroraCommandContext and patch

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869/#review76007 --- Ship it! LGTM once `self` or `cls` are used in place of class

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869/ --- (Updated March 11, 2015, 12:17 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney
On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 282 https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282 My understanding was that zmanji was attempting to remove AuroraCommandContext and patch

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/#review76008 ---

Re: Review Request 31570: Suppressing duplicate update instance events.

2015-03-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31570/ --- (Updated March 11, 2015, 12:19 a.m.) Review request for Aurora, David

Re: Review Request 31918: Improve response logging in TRequestsTransport

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31918/#review76013 --- Ship it! Master (b53e023) is green with this patch.

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread David McLaughlin
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 48 https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48 Do we really want to fail an operation when a message gets too long?

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869/ --- (Updated March 11, 2015, 12:26 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Maxim Khutornenko
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 48 https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48 Do we really want to fail an operation when a message gets too long?

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869/#review76019 --- Ship it! Master (b53e023) is green with this patch.