---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/#review76025
---
Master (b53e023) is red with this patch.
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
On March 7, 2015, 5:30 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java,
line 326
https://reviews.apache.org/r/31821/diff/1/?file=888148#file888148line326
Not yours, but it seems odd that we would call a function and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75901
---
Ship it!
Master (1b1931c) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 10, 2015, 5:44 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/
---
(Updated March 10, 2015, 6 p.m.)
Review request for Aurora and Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/
---
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/
---
(Updated March 11, 2015, 2:53 a.m.)
Review request for Aurora and Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76022
---
Ship it!
Master (b53e023) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review76037
---
Ship it!
Master (eb392b3) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/
---
(Updated March 10, 2015, 12:45 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75929
---
Ship it!
Master (48dc4c7) is green with this patch.
On March 10, 2015, 11:48 a.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java,
lines 59-62
https://reviews.apache.org/r/31820/diff/3/?file=889978#file889978line59
Maybe move this to the ticket and kill the commented out code
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75959
---
Ship it!
Master (48dc4c7) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/#review75923
---
Ship it!
Master (48dc4c7) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75954
---
Ship it!
Ship It!
- Bill Farner
On March 10, 2015, 7:45 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review75989
---
Ship it!
Master (48dc4c7) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/
---
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-1181
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/#review75994
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 10, 2015, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31918/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review75997
---
src/main/python/apache/aurora/client/base.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75980
---
src/main/python/apache/aurora/client/api/__init__.py
On March 11, 2015, 12:08 a.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 282
https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282
My understanding was that zmanji was attempting to remove
AuroraCommandContext and patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31918/#review76002
---
Ship it!
Ship It!
- Zameer Manji
On March 10, 2015, 5:05 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76004
---
Ship it!
Ship It!
- David McLaughlin
On March 11, 2015, 12:04
On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 282
https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282
My understanding was that zmanji was attempting to remove
AuroraCommandContext and patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review76007
---
Ship it!
LGTM once `self` or `cls` are used in place of class
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 11, 2015, 12:17 a.m.)
Review request for Aurora, Kevin Sweeney
On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 282
https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282
My understanding was that zmanji was attempting to remove
AuroraCommandContext and patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76008
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/
---
(Updated March 11, 2015, 12:19 a.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31918/#review76013
---
Ship it!
Master (b53e023) is green with this patch.
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 11, 2015, 12:26 a.m.)
Review request for Aurora, Kevin Sweeney
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review76019
---
Ship it!
Master (b53e023) is green with this patch.
37 matches
Mail list logo