Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-04 Thread Dan Norris
3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-04 Thread Dan Norris
3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Dan Norris
in master. Thanks, Dan Norris

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Dan Norris
, 2014, 12:42 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 12:42 a.m

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Dan Norris
, Dan Norris

Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-02 Thread Dan Norris
Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris

Re: Review Request 21402: Add python checkstyle hooks.

2014-05-16 Thread Dan Norris
/21402/#comment77101 Could you consolidate checkstyle and checkstyle check by sourcing the venv and calling deactivate once you're done? - Dan Norris On May 13, 2014, 8:04 p.m., Brian Wickman wrote: --- This is an automatically

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-05-16 Thread Dan Norris
? It probably needs to be rebased again since it's been sitting for awhile. - Dan Norris On April 29, 2014, 3:15 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-05-16 Thread Dan Norris
'/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris

Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

2014-05-06 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21055/#review42340 --- On May 4, 2014, 12:02 a.m., Dan Norris wrote: --- This is an automatically generated e

Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

2014-05-03 Thread Dan Norris
0b143d0a2cbb25c1d35f79963478800a6b6713ec Diff: https://reviews.apache.org/r/21055/diff/ Testing (updated) --- ./build-support/jenkins/build_mesos.sh ./pants src/test/python/apache/aurora/executor:executor-large -vxs (what the new build_executor.sh script does) Thanks, Dan Norris

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-04-28 Thread Dan Norris
FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris

Re: Review Request 20744: Upgrade Mesos to 0.18.0

2014-04-27 Thread Dan Norris
2b2ab0d93532bc4fdb3425aac4b306055067c6fe Diff: https://reviews.apache.org/r/20744/diff/ Testing --- Ran e2e test locally: + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Dan Norris

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-04-26 Thread Dan Norris
FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris

Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown

2014-04-24 Thread Dan Norris
, though I've updated the Jira ticket with a comparison between the two rendered tables. Commit on Github: https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97 Thanks, Dan Norris

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
or THROTTLED states. Thanks, Dan Norris

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
should be up shortly. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41146 --- On April 23, 2014, 3:02 p.m., Dan Norris

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
or THROTTLED states. Thanks, Dan Norris

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
92045c41706ee9315f3522c3b5bbff7f6e7d2c64 Diff: https://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris

Re: Review Request 20249: AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties

2014-04-10 Thread Dan Norris
/upstart/aurora-scheduler.log; sudo start aurora-scheduler. No more message about a missing log4j appender. Thanks, Dan Norris

Re: Review Request 20027: AURORA-234: Consider using markdown-style tables instead of HTML

2014-04-08 Thread Dan Norris
renders correctly, though I've updated the Jira ticket with a comparison between the two rendered tables. Commit on Github: https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97 Thanks, Dan Norris

Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown

2014-04-08 Thread Dan Norris
, Dan Norris

Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-08 Thread Dan Norris
://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris

Re: Review Request 19958: Revert AURORA-29: Clean up resource files under src/resources/org/apache/

2014-04-02 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19958/#review39355 --- Ship it! Ship It! - Dan Norris On April 2, 2014, 8:49 p.m

Review Request 19819: AURORA-29: Clean up resource files under src/resources/org/apache/

2014-03-28 Thread Dan Norris
7c7dc4749c3da9e16116d35b41ba6065541e87ea Diff: https://reviews.apache.org/r/19819/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs Thanks, Dan Norris

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-03-21 Thread Dan Norris
/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-03-10 Thread Dan Norris
or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan

Re: Review Request 18913: Bump protobuf version to match version used by mesos library.

2014-03-07 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18913/#review36550 --- Ship it! Ship It! - Dan Norris On March 7, 2014, 6:19 p.m

Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-02-26 Thread Dan Norris
wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

2014-02-24 Thread Dan Norris
with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

2014-02-24 Thread Dan Norris
45686aec8d69f0dfa1d649a92a19ca87bd315823 Diff: https://reviews.apache.org/r/17877/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs along with manual testing w/ bad arguments. Thanks, Dan Norris

Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

2014-02-20 Thread Dan Norris
4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

2014-02-14 Thread Dan Norris
--- On Feb. 10, 2014, 7:17 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17877

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

2014-02-10 Thread Dan Norris
45686aec8d69f0dfa1d649a92a19ca87bd315823 Diff: https://reviews.apache.org/r/17877/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs along with manual testing w/ bad arguments. Thanks, Dan Norris

Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

2014-02-08 Thread Dan Norris
/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs along with manual testing w/ bad arguments. Thanks, Dan Norris

Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent

2014-02-05 Thread Dan Norris
/test_gc_executor.py 0359098a2e25f68696cd24f9549bc19e73e55ea3 src/test/python/apache/aurora/executor/test_thermos_executor.py d91c3b06005ae6fa0fa7b23429a01fe1af68f178 Diff: https://reviews.apache.org/r/17734/diff/ Testing --- ./gradlew build ./pants src/test/python:all -vxs Thanks, Dan

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

2014-02-03 Thread Dan Norris
and running aurora_client.pex get_quota -h shows the updated text for the --cluster option. Thanks, Dan Norris

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

2014-02-02 Thread Dan Norris
aurora_client.pex get_quota -h shows the updated text for the --cluster option. Thanks, Dan Norris

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Dan Norris
/commands/admin.py 6d191f406a284c60326a49aed32914c81522d4d2 Diff: https://reviews.apache.org/r/17581/diff/ Testing --- Passes local tests. I could not find a test that tests the quota for the cli client so this patch does not contain an dedicated test case. Thanks, Dan Norris

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Dan Norris
an dedicated test case. Thanks, Dan Norris