Re: Review Request 32371: Refine types used in QuotaManager, share more functions/predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32371/#review77667 --- Ship it! Ship It! - Maxim Khutornenko On March 21, 2015, 7:42

Re: Review Request 32352: Making preemptor asynchronous. Part 3(final) - background service.

n is created but can't be used right away as currently coded.** - Round 3: Pending task fails to schedule, reservation is found and task is finally scheduled. - Maxim --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 32359: Adding a configurable delay into writing a backup file.

os.monitoring.test_disk > > . SUCCESS > > > > FAILURE > > > >  > >FAILURE > > > > > > I will refresh this build result if you post a review containing > > &

Re: Review Request 32359: Adding a configurable delay into writing a backup file.

ecfc4 src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java ebe551739fb6b7132ce666ad9b3c5a86e90a5363 Diff: https://reviews.apache.org/r/32359/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32359: Adding a configurable delay into writing a backup file.

Let me know if you still think it's not clear or have another alternative. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32359/#review77337 -

Re: Review Request 32352: Making preemptor asynchronous. Part 3(final) - background service.

ultiple pending tasks. Will file a ticket to capture all these points. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32352/#review77348 ------

Re: Review Request 32369: Simplify port name association.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32369/#review77417 --- Ship it! Ship It! - Maxim Khutornenko On March 21, 2015, 5:49

Review Request 32359: Adding a configurable delay into writing a backup file.

ebe551739fb6b7132ce666ad9b3c5a86e90a5363 Diff: https://reviews.apache.org/r/32359/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 32352: Making preemptor asynchronous. Part 3(final) - background service.

: https://reviews.apache.org/r/32352/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Review Request 32353: Renaming PreemptionSlotFinder.

/scheduler/async/preemptor/PreemptorSlotFinderTest.java b80e558f18b817814e4768b13ff94aa816d28543 Diff: https://reviews.apache.org/r/32353/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32276: Fix error listing active updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32276/#review77152 --- Ship it! Ship It! - Maxim Khutornenko On March 20, 2015, 1:46

Re: Review Request 32225: Adding preemptor jmh benchmark

c9d10e4cec44045806ec2d75d8c158dc40d7de98 Diff: https://reviews.apache.org/r/32225/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

52#file899552line84> > > > > Given that you probably want a singleton PreemptionSlotCache, don't > > forget to bind that as such here. Good idea. Done. - Maxim --- This is an automatically genera

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

tring to have this ugliness contained in a single place. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32220/#review77112 -------

Re: Review Request 32171: Change "update list" subcommand to accept a hierarchy.

hon/apache/aurora/client/cli/update.py <https://reviews.apache.org/r/32171/#comment124999> While it's converted to set by thrift anyway, I'd still recommend using a set() here to explicitly assert no duplicates are ever accepted. - Maxim Khutornenko On

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

://reviews.apache.org/r/32220/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32225: Adding preemptor jmh benchmark

/PreemptorModuleTest.java c9d10e4cec44045806ec2d75d8c158dc40d7de98 Diff: https://reviews.apache.org/r/32225/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko

Review Request 32225: Adding preemptor jmh benchmark

, Maxim Khutornenko

Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

cfbc1a039262d92481ded2733d50ac51293a5b91 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorSlotFinderTest.java e329358f70028f52a807cd987378cbc002af36a9 Diff: https://reviews.apache.org/r/32220/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32208: Reduce loglevel for insufficient GC resources to fine

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32208/#review76919 --- Ship it! Ship It! - Maxim Khutornenko On March 18, 2015, 6:28

Re: Review Request 32171: Change "update list" subcommand to accept a hierarchy.

> On March 18, 2015, 12:04 a.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/client/cli/test_supdate.py, lines 404-406 > > > > > > How would you feel about including all of the currently available data > >

Re: Review Request 32181: Only warn about insufficient GC resources when actually needed

> On March 17, 2015, 11:12 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java, > > line 208 > > <https://reviews.apache.org/r/32181/diff/1/?file=898407#file898407line208> > > > > This reordering w

Re: Review Request 32181: Only warn about insufficient GC resources when actually needed

collection. - Maxim Khutornenko On March 17, 2015, 10:50 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 32171: Change "update list" subcommand to accept a hierarchy.

tps://reviews.apache.org/r/32171/#comment124508> How about adding all statuses here to allow searching by a specific job update status in addition to a group? src/main/python/apache/aurora/client/cli/update.py <https://reviews.apache.org/r/32171/#comment124503> typo - Maxim Khut

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

/AnnotatedAuroraAdmin.java <https://reviews.apache.org/r/32141/#comment12> You probably want @Nullable here as well. src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java <https://reviews.apache.org/r/32141/#comment124445> same here - Maxim Khut

Re: Review Request 32164: Moving pending task search into PreemptorImpl

t this stage just to return it back shortly after. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32164/#review76753 ----------

Review Request 32164: Moving pending task search into PreemptorImpl

-Pq build Thanks, Maxim Khutornenko

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

otated with @Nullable. - Maxim Khutornenko On March 17, 2015, 1:29 a.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 32077: Rename beta-update subcommand to update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32077/#review76636 --- Ship it! Ship It! - Maxim Khutornenko On March 16, 2015, 5:57

Re: Review Request 32078: Remove the populatedDEPRECATED thrift field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32078/#review76632 --- Ship it! Ship It! - Maxim Khutornenko On March 16, 2015, 5:39

Re: Review Request 32106: Changed the updater to not update an instance if only the job owner changes

in the update working set, which does not reflect the NOOP nature of this action. [1] - https://github.com/apache/incubator-aurora/blob/master/src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java - Maxim Khutornenko On March 16, 2015, 3:13 p.m., Steve Niemitz

Re: Review Request 32014: Adding more logging into MaintenanceController.

bd031a5e0b7d2923e36ca5958c5074f40dc64848 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/32014/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32014: Adding more logging into MaintenanceController.

.java bd031a5e0b7d2923e36ca5958c5074f40dc64848 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/32014/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32014: Adding more logging into MaintenanceController.

/MaintenanceController.java b6f642e319b790544bc538098e7cb78b1bb49997 src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java bd031a5e0b7d2923e36ca5958c5074f40dc64848 Diff: https://reviews.apache.org/r/32014/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim

Re: Review Request 32014: Adding more logging into MaintenanceController.

d log entry to have. Can it be done in the client > > instead? > > Maxim Khutornenko wrote: > Client already has logs but that's not enough to reconstruct the behavior > when maintenance stalls. We need to see both sides of the story to properly > troubleshoot hos

Re: Review Request 32048: Build all components before running the end-to-end tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32048/#review76375 --- Ship it! Ship It! - Maxim Khutornenko On March 13, 2015, 3:45

Re: Review Request 32014: Adding more logging into MaintenanceController.

d log entry to have. Can it be done in the client > > instead? > > Maxim Khutornenko wrote: > Client already has logs but that's not enough to reconstruct the behavior > when maintenance stalls. We need to see both sides of the story to properly > troubleshoot hos

Re: Review Request 32014: Adding more logging into MaintenanceController.

ews.apache.org/r/32014/#review76332 --- On March 13, 2015, 1:23 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Review Request 32014: Adding more logging into MaintenanceController.

/state/MaintenanceControllerImplTest.java bd031a5e0b7d2923e36ca5958c5074f40dc64848 Diff: https://reviews.apache.org/r/32014/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31913: Added 'none' host maintenance grouping function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76307 --- Thanks, it's now on master. - Maxim Khutornenko On Mar

Re: Review Request 31913: Added 'none' host maintenance grouping function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76304 --- Ship it! Thanks! - Maxim Khutornenko On March 12, 2015, 11:13

Re: Review Request 31913: Added 'none' host maintenance grouping function.

tps://reviews.apache.org/r/31913/#comment123803> Mind adding a host maintenance test instead? I am concerned this may drift over time and will no longer represent how the grouping is actually used. - Maxim Khutornenko On March 11, 2015, 2:53 a.m., David Robinson

Re: Review Request 31966: Add client support for including messages when changing update state.

66/#comment123754> Mind sorting them alphabetically? - Maxim Khutornenko On March 12, 2015, 1:27 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

urora/scheduler/async/preemptor/PreemptorSlotFinderTest.java PRE-CREATION Diff: https://reviews.apache.org/r/31821/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

> On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, > > line 48 > > <https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48> > > > > Do we really w

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

> On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, > > line 48 > > <https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48> > > > > Do we really w

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

/JobUpdateController.java <https://reviews.apache.org/r/31916/#comment123392> Do we really want to fail an operation when a message gets too long? Since it's optional anyway, I'd expect truncation could be a more resilient way to handle this. - Maxim Khutornenko On March 11, 2015, 12:04 a

Re: Review Request 31570: Suppressing duplicate update instance events.

--- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Re: Review Request 31913: Added 'none' host maintenance grouping function.

ceback (most recent call last): File "", line 1, in File "", line 1, in TypeError: 'NoneType' object has no attribute '__getitem__' ``` Please, add a typed default grouping (e.g. "ALL") and a correspondent test in tes

Re: Review Request 31901: Export task status reason counters whenever they are present.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31901/#review75994 --- Ship it! Ship It! - Maxim Khutornenko On March 10, 2015, 6 p.m

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

, but it seems odd that we would call a function and > > internally suppress its behavior based on configuration. Seems like the > > caller should avoid the call if the behavior is not desired. If you agree, > > please TODO. > > Maxim Khutornenko wrote: > Not s

Re: Review Request 31570: Suppressing duplicate update instance events.

--- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31821/#review75816 --- @ReviewBot retry - Maxim Khutornenko On March 9, 2015, 11:34 p.m

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

org/apache/aurora/scheduler/async/preemptor/PreemptorSlotFinderTest.java PRE-CREATION Diff: https://reviews.apache.org/r/31821/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

and make the caller mutate the result for any additional customization. > > > > Consider this as a TODO for now, so we can avoid further modification > > of the test cases. However, in this diff please correct the line wrap > > style on the arguments. > >

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/31821/#review75743 ------- On March 7, 2015, 1:36 a.m., Maxim Khutornenko wrote: > > --- > This is an au

Re: Review Request 31525: Improving NearestFit reporting accuracy.

/NearestFitTest.java e0f9d8b4c3d80b70faa10612b82a034e3dae9112 Diff: https://reviews.apache.org/r/31525/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31814: Include messages with internal job updater state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75786 --- Ship it! Ship It! - Maxim Khutornenko On March 7, 2015, 1:06

Re: Review Request 31814: Include messages with internal job updater state transitions.

> On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 291 > > <https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291> > > > > What'

Re: Review Request 31814: Include messages with internal job updater state transitions.

> On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 291 > > <https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291> > > > > What'

Re: Review Request 31869: Catch only known Exception types in the client.

tps://reviews.apache.org/r/31869/#comment123014> why not just "context"? - Maxim Khutornenko On March 9, 2015, 8:10 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 31814: Include messages with internal job updater state transitions.

/JobUpdateControllerImpl.java <https://reviews.apache.org/r/31814/#comment122955> What's the motivation behind dropping the "Aurora Updater" here? - Maxim Khutornenko On March 7, 2015, 1:06 a.m., Bill Farner wrote: > > ---

Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

://reviews.apache.org/r/31821/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31779/#review75559 --- Ship it! Ship It! - Maxim Khutornenko On March 6, 2015, 10:38

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

/JobUpdateControllerImpl.java <https://reviews.apache.org/r/31779/#comment122499> This change loses the "active" filter where it's actually vital. Recommend refactoring `queryActiveByJob` to take a `IJobUpdateKey` instead. - Maxim Khutornenko On March 5, 2015, 11:10 p.

Re: Review Request 31753: Add storage support for associating a message with job update events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31753/#review75391 --- Ship it! Ship It! - Maxim Khutornenko On March 5, 2015, 1:19

Re: Review Request 31652: Returning pending reason for all tasks in a group

src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java ce5a62650cebab9a53743460f5a5119f62efec1c Diff: https://reviews.apache.org/r/31652/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31652: Returning pending reason for all tasks in a group

uld this cache be renamed? No preference here, renamed. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31652/#review75096 ---------

Re: Review Request 31646: Moving GroupKey to scheduler.base.

adlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31646: Moving GroupKey to scheduler.base.

roxy method to the constructor? To highlight the immutable final purpose of its existence. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31646/#review75093 --

Re: Review Request 31751: Adding missing service binding into UpdaterModule.

src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 216849145fe681d05ed54ac7fbf385bb31d8cdea Diff: https://reviews.apache.org/r/31751/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 31751: Adding missing service binding into UpdaterModule.

start`? Did not notice restart command. Changed. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31751/#review75272 --------

Re: Review Request 31751: Adding missing service binding into UpdaterModule.

.java 5733da3daeacd8cb726310e5d9933635e3993687 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 216849145fe681d05ed54ac7fbf385bb31d8cdea Diff: https://reviews.apache.org/r/31751/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Review Request 31751: Adding missing service binding into UpdaterModule.

/test_end_to_end.sh 216849145fe681d05ed54ac7fbf385bb31d8cdea Diff: https://reviews.apache.org/r/31751/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 31739: Making task preemption asynchronous.

> On March 4, 2015, 8:17 p.m., Bill Farner wrote: > > Is there a reason you did not opt to implement this behind the `Preemptor` > > interface? Seems like if you went with that approach, `TaskScheduler` can > > be oblivious to the background operations. > &

Re: Review Request 31739: Making task preemption asynchronous.

quot; preemption benchmark but we should probably do so when we try to optimize the preemptor algorithm itself. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31739/#review75247 ---

Re: Review Request 31739: Making task preemption asynchronous.

> On March 4, 2015, 8:17 p.m., Bill Farner wrote: > > Is there a reason you did not opt to implement this behind the `Preemptor` > > interface? Seems like if you went with that approach, `TaskScheduler` can > > be oblivious to the background operations. > &

Re: Review Request 31739: Making task preemption asynchronous.

/reviews.apache.org/r/31739/#review75226 --- On March 4, 2015, 7:30 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 31739: Making task preemption asynchronous.

s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31739/#review75222 --- On March 4, 2015, 7:30 p.m., Maxim Khutornenko wrote: > >

Re: Review Request 31739: Making task preemption asynchronous.

uler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422 Diff: https://reviews.apache.org/r/31739/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Re: Review Request 31716: Add an end-to-end test for scheduler-driven job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31716/#review75213 --- Ship it! Ship It! - Maxim Khutornenko On March 4, 2015, 7:01

Review Request 31739: Making task preemption asynchronous.

che/aurora/scheduler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422 Diff: https://reviews.apache.org/r/31739/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Re: Review Request 31716: Add an end-to-end test for scheduler-driven job updates.

tps://reviews.apache.org/r/31716/#comment122085> kill newline src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh <https://reviews.apache.org/r/31716/#comment122084> Should it also include a pause/resume cycle? - Maxim Khutornenko On March 4, 2015, 1:21 a.m., Bill

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

<https://reviews.apache.org/r/31710/#comment122025> You may want to extract an internal method to do this, e.g.: ``` def timestamp(time_msec): return time.ctime(time_msec / 1000) ``` - Maxim Khutornenko On March 3, 2015, 11:44 p.m., Bill Farner

Re: Review Request 31659: Clean up end-to-end tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review75045 --- Ship it! Ship It! - Maxim Khutornenko On March 3, 2015, 8:53

Re: Review Request 31659: Clean up end-to-end tests.

tps://reviews.apache.org/r/31659/#comment121886> Not directly related but adding --batch-size=2 would make it even faster. - Maxim Khutornenko On March 3, 2015, 3:23 a.m., Bill Farner wrote: > > --- > This is an automatically g

Re: Review Request 31659: Clean up end-to-end tests.

<https://reviews.apache.org/r/31659/#comment121857> Is this statement still accurate now that ssh is dropped from the command? - Maxim Khutornenko On March 3, 2015, 3:23 a.m., Bill Farner wrote: > > --- > This is a

Re: Review Request 31652: Returning pending reason for all tasks in a group

/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java ce5a62650cebab9a53743460f5a5119f62efec1c Diff: https://reviews.apache.org/r/31652/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 31652: Returning pending reason for all tasks in a group

/31652/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 31646: Moving GroupKey to scheduler.base.

4ee13c8e5d46ba863f4d9871884c7d494d07758d src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422 Diff: https://reviews.apache.org/r/31646/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31525: Improving NearestFit reporting accuracy.

/NearestFitTest.java 78a236c0f9074692b67ce18e6e03f18fe4529e02 Diff: https://reviews.apache.org/r/31525/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31525: Improving NearestFit reporting accuracy.

t;. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74801 ------- On Feb. 27, 2015, 9:05 p.m., Maxim Khutornenk

Re: Review Request 31525: Improving NearestFit reporting accuracy.

t; c3097e49c0f6588ea765aa4fab69dd35e3d90e8b > > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java > b00668423a53a8cf6f4da3456bce3354f1fd2424 > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > 78a236c0f9074692b67ce18e6e03f18fe4529e02 > > Diff: https://reviews.apache.org/r/31525/diff/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >

Re: Review Request 31570: Suppressing duplicate update instance events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31570/#review74649 --- @ReviewBot retry - Maxim Khutornenko On Feb. 28, 2015, 1:37 a.m

Review Request 31570: Suppressing duplicate update instance events.

acdade3dca807a221b4da975d0310c91884ee752 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e24d6bde5f3479a75522e825cce4ec6c30c117aa Diff: https://reviews.apache.org/r/31570/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Review Request 31565: Build fix.

://reviews.apache.org/r/31565/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31525: Improving NearestFit reporting accuracy.

adata/NearestFitTest.java 78a236c0f9074692b67ce18e6e03f18fe4529e02 Diff: https://reviews.apache.org/r/31525/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31558/#review74586 --- @ReviewBot retry - Maxim Khutornenko On Feb. 27, 2015, 8:13 p.m

Re: Review Request 31525: Improving NearestFit reporting accuracy.

res definitions into the VetoType enum. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74554 ------- On

  1   2   3   4   5   6   7   8   9   10   >