Re: Review Request 32515: Kill inotify disk collector.

-916 when this lands. - Zameer Manji On March 25, 2015, 6:19 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32352: Making preemptor asynchronous. Part 3(final) - background service.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32352/#review77425 --- Ship it! Ship It! - Zameer Manji On March 20, 2015, 7:19 p.m

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

ble because Job() is a pystachio object but I strongly suggest investigating it. This way if we try to access other attributes the test will fail. - Zameer Manji On March 20, 2015, 10:26 a.m., Bill Farner wrote: > > --- >

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

/preemptor/PreemptionSlotFinder.java <https://reviews.apache.org/r/32220/#comment125005> This is a bit confusing to see .getSlaveId and then construct an instance of SlaveID. Perhaps preemptionSlot should return a SlaveID instance? - Zameer Manji On March 18, 2015, 5:29 p.m., Maxim Khuto

Re: Review Request 32171: Change "update list" subcommand to accept a hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32171/#review77101 --- Ship it! Ship It! - Zameer Manji On March 19, 2015, 1:22 p.m

Re: Review Request 32171: Change "update list" subcommand to accept a hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32171/#review76844 --- Ship it! Ship It! - Zameer Manji On March 17, 2015, 1:50 p.m

Re: Review Request 32171: Change "update list" subcommand to accept a hierarchy.

values. src/main/python/apache/aurora/client/cli/update.py <https://reviews.apache.org/r/32171/#comment124499> No need for .dedent here. - Zameer Manji On March 17, 2015, 1:50 p.m., Bill Farner wrote: > > --- > This

Re: Review Request 32013: Cache TaskDetectors for reuse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76822 --- Ship it! Ship It! - Zameer Manji On March 17, 2015, 1:24 p.m

Re: Review Request 32013: Cache TaskDetectors for reuse.

<https://reviews.apache.org/r/32013/#comment124450> What's the rationale behind this change? I think the callers should be doing the checking for existance and dealing with missing directories as needed. - Zameer Manji On March 16, 2015, 3:37 p.m., Brian Wi

Review Request 32131: Get CI to build python sdists.

/python/apache/thermos/bin/BUILD 669f9930a3590184dc0f8b5c15c36168e715eb03 Diff: https://reviews.apache.org/r/32131/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji

Re: Review Request 32077: Rename beta-update subcommand to update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32077/#review76599 --- Ship it! Pending e2e test results. - Zameer Manji On March 16

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76409 --- Ship it! Ship It! - Zameer Manji On March 13, 2015, 12:38 p.m

Re: Review Request 31966: Add client support for including messages when changing update state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76257 --- Ship it! Ship It! - Zameer Manji On March 11, 2015, 6:27 p.m

Re: Review Request 31869: Catch only known Exception types in the client.

pdated March 10, 2015, 10:44 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-1176 > https://issues.apache.org/jira/browse/AURORA-1176 > > > Repository: aurora > > > Description > --- > > As indicat

Re: Review Request 31918: Improve response logging in TRequestsTransport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31918/#review76002 --- Ship it! Ship It! - Zameer Manji On March 10, 2015, 5:05 p.m

Re: Review Request 31869: Catch only known Exception types in the client.

tps://reviews.apache.org/r/31869/#comment123011> Use pytest.raises for tests where you expect an exception to be raised: http://pytest.org/latest/assert.html src/test/python/apache/aurora/client/cli/util.py <https://reviews.apache.org/r/31869/#comment123013> +100 - Zameer Manji

Re: Review Request 31869: Catch only known Exception types in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869/#review75765 --- Ship it! Ship It! - Zameer Manji On March 9, 2015, 1:10 p.m

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

gt; --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31821/ > --- > > (Updated March 6, 2015, 5:36 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > >

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31821/ > --- > > (Updated March 6, 2015, 5:36 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. &

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

/preemptor/PreemptionSlotFinder.java <https://reviews.apache.org/r/31821/#comment122986> To keep the implementation package private, could you move it to another file? - Zameer Manji On March 6, 2015, 5:36 p.m., Maxim Khutornenko

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

g/r/31820/#comment122972> Can you increment a stat here? It seems these failures would be of interest to an operator. - Zameer Manji On March 6, 2015, 4:54 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-

Re: Review Request 31774: Add aurora-specific entry point for thermos observer and fix /vars

he.org/r/31774/#comment122453> This duplicates some code in twitter.common.app. Is this code not available in the sdists? src/main/python/apache/thermos/observer/http/diagnostics.py <https://reviews.apache.org/r/31774/#comment122452> If we can import PEX, shouldn't this be impos

Re: Review Request 31774: Add aurora-specific entry point for thermos observer and fix /vars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31774/#review75417 --- Ship it! Ship It! - Zameer Manji On March 5, 2015, 12:31 p.m

Re: Review Request 31739: Making task preemption asynchronous.

you explain the reason for the delay? We already wait for a task to be pending for 10 minutes before we do preemption, I don't see the reason for another delay until we look for a victim. - Zameer Manji On March 4, 2015, 11:30 a.m., Maxim

Re: Review Request 31714: Suppress empty RPC response logging from the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31714/#review75123 --- Ship it! Ship It! - Zameer Manji On March 3, 2015, 4:59 p.m

Re: Review Request 31652: Returning pending reason for all tasks in a group

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31652/#review75099 --- Ship it! Ship It! - Zameer Manji On March 2, 2015, 4:58 p.m

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

> On March 3, 2015, 3:21 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/client/cli/test_supdate.py, line 211 > > <https://reviews.apache.org/r/31710/diff/1/?file=883801#file883801line211> > > > > F

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

tps://reviews.apache.org/r/31710/#comment122016> For the calls like this you can do `mock_api.pause_job_update.assert_called_once_with(self.TEST_JOBKEY)` instead of comparing against an array of call objects. - Zameer Manji On March 3, 2015, 3:16 p.m., Bill Farner

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review75082 --- Ship it! Ship It! - Zameer Manji On March 3, 2015, 2:58 p.m

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

tps://reviews.apache.org/r/31559/#comment121996> shouldn't closing the checkpoint and killing the task runner be in a finally clause? - Zameer Manji On March 3, 2015, 2:14 p.m., Brian Wickman wrote: > > --- > This

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

> On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote: > > src/main/python/apache/thermos/cli/common.py, line 40 > > <https://reviews.apache.org/r/31559/diff/1/?file=880707#file880707line40> > > > > Unrelated to your change, why have the strict option at al? Sho

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

> On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote: > > src/test/python/apache/thermos/cli/commands/test_simplerun.py, line 19 > > <https://reviews.apache.org/r/31559/diff/1/?file=880712#file880712line19> > > > > Instead of creating a Mock like this here, cou

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

b the options from the simplerun command? If you do that then you can create a Mock with a spec_set. - Zameer Manji On Feb. 27, 2015, 12:58 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

sense to have rollback with restarts right? - Zameer Manji On Feb. 27, 2015, 12:13 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31508/#review74546 --- Ship it! Ship It! - Zameer Manji On Feb. 26, 2015, 4:04 p.m

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31508/ > --- > > (Updated Feb. 26, 2015, 4:04 p.m.) > > > Review request for Aurora

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74543 --- Ship it! Ship It! - Zameer Manji On Feb. 27, 2015, 9:54 a.m

Re: Review Request 31496: Set default people for reviews.

n Feb. 26, 2015, 1:57 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31496/ > --- &

Review Request 31496: Set default people for reviews.

Description --- Set default people for reviews so reviews made by new contributors have reviewers. Diffs - .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d Diff: https://reviews.apache.org/r/31496/diff/ Testing --- Made this review. Thanks, Zameer Manji

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74345 --- Ship it! Ship It! - Zameer Manji On Feb. 26, 2015, 11:46 a.m

Re: Review Request 31451: Port thermos observer to the path detector interface

tha lock but none of the callbacks are? I think either the detector should have an internal lock to prevent concurrent refreshes or the lock here should also be used to protect the callbacks that are passed in. - Zameer Manji On Feb. 25, 2015, 5:50 p

Re: Review Request 31453: Run python style checks before unit tests in build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31453/#review74197 --- Ship it! Ship It! - Zameer Manji On Feb. 25, 2015, 5:41 p.m

Re: Review Request 31451: Port thermos observer to the path detector interface

> > (Updated Feb. 25, 2015, 5:50 p.m.) > > > Review request for Aurora, Joe Smith and Zameer Manji. > > > Bugs: AURORA-1026 > https://issues.apache.org/jira/browse/AURORA-1026 > > > Repository

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74193 --- Ship it! Ship It! - Zameer Manji On Feb. 25, 2015, 5:39 p.m

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

k with json.loads(mock_context.get_out_str()) == json.loads(""fixture"") Even nicer would be to make the LHS a python dict to compare against the json.loads. - Zameer Manji On Feb. 25, 2015, 3:04 p.m., Bill Farner wrote: > >

Re: Review Request 31445: Expose more details about the tasks the preemptor is working for.

/preemptor/PreemptorImpl.java <https://reviews.apache.org/r/31445/#comment120642> I think some JavaDoc explaining which stats are exported would be nice. This would enable an operator/user to grep the source to see which code is responsible for a stat. - Zameer Manji On Feb. 25, 2015, 2:

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31423/ > --- > > (Updated Feb. 25, 2015, 1:22 p.m.) > > > Review request for Aurora, Brian Wickman

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

before shutting down the task. - Zameer Manji On Feb. 25, 2015, 1:22 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31376: Introduce JobUpdateSummary.key field, dual write that field when it is read/received.

ler/storage/db/JobUpdateDetailsMapper.xml <https://reviews.apache.org/r/31376/#comment120339> Have you filed an upstream bug about this behaviour? - Zameer Manji On Feb. 24, 2015, 12:12 p.m., Bill Farner wrote: > > --- >

Re: Review Request 31376: Introduce JobUpdateSummary.key field, dual write that field when it is read/received.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31376/#review73907 --- Ship it! Ship It! - Zameer Manji On Feb. 24, 2015, 12:12 p.m

Re: Review Request 31251: Fix swallowed exceptions in health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31251/#review73707 --- Ship it! Ship It! - Zameer Manji On Feb. 23, 2015, 3:09 p.m

Re: Review Request 31251: Fix swallowed exceptions in health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31251/#review73650 --- Ship it! Ship It! - Zameer Manji On Feb. 23, 2015, 11:50 a.m

Re: Review Request 31251: Fix swallowed exceptions in health check test.

<https://reviews.apache.org/r/31251/#comment120044> log.error since this is completely unexpected behaviour - Zameer Manji On Feb. 23, 2015, 11:50 a.m., Brian Wickman wrote: > > --- > This is an automatically generated e

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

> On Feb. 19, 2015, 1:11 p.m., Zameer Manji wrote: > > Ship it, modulo my concern over uncessarily creating an IJobUpdateKey from > > PruneVictim. Bill clarified the creating IJobUpdateKey from PruneVictim offline. PruneVictim needs to have the mutable types so it can be

Review Request 31240: Remove render partial job key method.

/test/python/apache/aurora/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904 Diff: https://reviews.apache.org/r/31240/diff/ Testing --- ./pants test.pytest --no-fast src/test/python/apache/aurora/client:: Thanks, Zameer Manji

Re: Review Request 31240: Remove single caller methods from AuroraCommandContext

/ Testing --- ./pants test.pytest --no-fast src/test/python/apache/aurora/client:: Thanks, Zameer Manji

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

IJobUpdateKey from PruneVictim. - Zameer Manji On Feb. 19, 2015, 12:30 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

> On Feb. 18, 2015, 5:17 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, > > line 166 > > <https://reviews.apache.org/r/31170/diff/1/?file=868472#file868472line166> > > > > Shouldn'

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

oglecode.com/git/javadoc/com/google/common/collect/Sets.html#immutableEnumSet(java.lang.Iterable) instead. - Zameer Manji On Feb. 18, 2015, 4:19 p.m., Bill Farner wrote: > > --- > This is an automatically gener

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

/JobUpdateStore.java <https://reviews.apache.org/r/31170/#comment119201> s/t/it src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/31170/#comment119203> I think you can remove the TODO here. - Zameer Manji On Feb. 18, 2015, 4:1

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

) and Kevin Sweeny (kevints) to the People line of the review? - Zameer Manji On Feb. 16, 2015, 11:21 a.m., Craig Wickesser wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

gt; > included in the aurora project? > > Zameer Manji wrote: > The gradle wrapper is not apart of the source dists because of licensing > issues. So if you grab the source release from Apache you will need to > install gradle. Derp, I now see that the document points to the s

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

> On Feb. 14, 2015, 11:39 a.m., Florian Pfeiffer wrote: > > docs/build-for-centos.md, line 40 > > > > > > Installing gradle is probably not needed, since the gradle wrapper is > > included in the aurora project? The g

Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

the UpdateConfig are timeouts until a task enters the RUNNING state? - Zameer Manji On Feb. 16, 2015, 10:22 p.m., Moses Nakamura wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 31135: Pin protobuf dependency to 2.6.1

protobuf-2.6.1-py2.7.egg $ ./pants test.pytest --no-fast src/test/python:: Thanks, Zameer Manji

Re: Review Request 31124: Fix build break - remove unused imports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31124/#review72740 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2015, 10:09 a.m

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72739 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2015, 10 a.m

Re: Review Request 31022: Fixing aurora beta-update status command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72445 --- Ship it! Ship It! - Zameer Manji On Feb. 13, 2015, 2:15 p.m

Re: Review Request 31022: Fixing aurora beta-update status command.

tps://reviews.apache.org/r/31022/#comment118499> Shouldn't 'test' be self.TEST_CLUSTER or similar? - Zameer Manji On Feb. 13, 2015, 1:54 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically gen

Re: Review Request 30950: Add the option to make a non-hooked API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/#review72251 --- Ship it! Ship It! - Zameer Manji On Feb. 12, 2015, 1:59 p.m

Re: Review Request 30950: Add the option to make a non-hooked API.

tps://reviews.apache.org/r/30950/#comment118308> Why don't you just use the imported values instead of declaring them here again? - Zameer Manji On Feb. 12, 2015, 1:59 p.m., Joshua Cohen wrote: > > --- > This is an automatica

Re: Review Request 30681: docs: Expand Getting Started document

reviews.apache.org/r/30681/ > --- > > (Updated Feb. 6, 2015, 9:07 a.m.) > > > Review request for Aurora, Chris Aniszczyk, Dave Lester, Joshua Cohen, Marko > Gargenta, and Zameer Manji. > > > Repository: aurora > > > Description &

Re: Review Request 30710: add mesos role feature

> On Feb. 9, 2015, 4:56 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 117 > > <https://reviews.apache.org/r/30710/diff/2/?file=852094#file852094line117> > > > > I don

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71741 --- Ship it! Ship It! - Zameer Manji On Feb. 9, 2015, 3:16 p.m

Re: Review Request 30710: add mesos role feature

ere Mesos will reject protobufs as changed when we start setting a previously unset field to a default value. See https://issues.apache.org/jira/browse/MESOS-2309 for details. Currently as this stands, I think this will cause existing Aurora instances to be rejected by the Master. -

Re: Review Request 30749: Port GC executor to PathDetector interface

this change LGTM. - Zameer Manji On Feb. 9, 2015, 10:56 a.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 30768: Reject None values for TaskPath

- Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30768/#review71589 ------- On Feb. 9, 2015, 10:47 a.m., Zameer Manji wrote: > > -

Re: Review Request 30768: Reject None values for TaskPath

/executor:: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 30768: Reject None values for TaskPath

:: ./pants test src/test/python/apache/aurora/executor:: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 30749: Port GC executor to PathDetector interface

xecutor.py <https://reviews.apache.org/r/30749/#comment117329> Shouldn't this log messsage be inside the collector implementation? - Zameer Manji On Feb. 6, 2015, 6:27 p.m., Brian Wickman wrote: > > --- > This is an aut

Review Request 30768: Reject None values for TaskPath

/30768/diff/ Testing --- ./pants test src/test/python/apache/thermos:: ./pants test src/test/python/apache/aurora/executor:: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 30741: Add an interface and implementations of PathDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/#review71487 --- Ship it! Ship It! - Zameer Manji On Feb. 6, 2015, 11:30 a.m

Review Request 30704: Remove default root in TaskPath.

://reviews.apache.org/r/30704/diff/ Testing --- ./pants test src/test/python/apache/thermos:: Thanks, Zameer Manji

Re: Review Request 30681: docs: Expand Getting Started document

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71303 --- Ship it! Ship It! - Zameer Manji On Feb. 5, 2015, 10:46 a.m

Re: Review Request 30681: docs: Expand Getting Started document

.org/r/30681/ > --- > > (Updated Feb. 5, 2015, 10:46 a.m.) > > > Review request for Aurora, Chris Aniszczyk, Marko Gargenta, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > docs: Expand Getting Star

Re: Review Request 30649: Upgrade pants to 0.0.28

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30649/#review71172 --- Ship it! Ship It! - Zameer Manji On Feb. 4, 2015, 8:13 p.m

Re: Review Request 30650: Upgrade virtualenv to 12.0.7

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30650/#review71171 --- Ship it! Ship It! - Zameer Manji On Feb. 4, 2015, 8:13 p.m

Re: Review Request 30586: Fix exception when opening cron urls.

tps://reviews.apache.org/r/30586/#comment116782> The config object in the argument is very complex and difficult to create. With our current set of test fixtures. - Zameer Manji On Feb. 4, 2015, 6:08 p.m., Zameer Manji wrote: > > --

Re: Review Request 30649: Upgrade pants to 0.0.28

sort of summary that explains what is new. - Zameer Manji On Feb. 4, 2015, 6:46 p.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 30586: Fix exception when opening cron urls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30586/#review71128 --- Maxim, can you review the changes to the tests? - Zameer Manji

Re: Review Request 30586: Fix exception when opening cron urls.

on.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/30586/diff/ Testing --- ./pants goal test src/test/python/apache/aurora/client/cli:cron Thanks, Zameer Manji

Re: Review Request 30585: Adding command hook for beta-update start.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/#review71014 --- Ship it! Ship It! - Zameer Manji On Feb. 3, 2015, 4:24 p.m

Re: Review Request 30586: Fix exception when opening cron urls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30586/#review70900 --- @ReviewBot retry - Zameer Manji On Feb. 3, 2015, 5:14 p.m

Re: Review Request 30586: Fix exception when opening cron urls.

----- On Feb. 3, 2015, 5:14 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30586/ >

Re: Review Request 30586: Fix exception when opening cron urls.

on.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/30586/diff/ Testing --- ./pants goal test src/test/python/apache/aurora/client/cli:cron Thanks, Zameer Manji

Re: Review Request 30585: Adding command hook for beta-update start.

gt; > I will refresh this build result if you post a review containing > > "@ReviewBot retry" George, can you fix the style issues? - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.

Review Request 30586: Fix exception when opening cron urls.

f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/30586/diff/ Testing --- ./pants goal test src/test/python/apache/aurora/client/cli:cron Thanks, Zameer Manji

Re: Review Request 30535: Remove shard uniqueness check from scheduler recovery phase.

> Diffs > > - > > > > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java > 1814658c044273f7c3a2348a16aea62e397cf860 > > > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java > 93773eb5ba3bee1b3296e69ea30eabb531eeb661 > > > > Diff: https://reviews.apache.org/r/30535/diff/ > > > > > > Testing > > --- > > > > > > Thanks, > > > > Bill Farner > > > > > > -- Zameer Manji

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

> On Jan. 30, 2015, 4:16 p.m., Zameer Manji wrote: > > Ship It! My comment got chompted, I'm expecting these tests to be run on Jenkins for every commit. - Zameer --- This is an automatically generated e-mail. To reply

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/#review70458 --- Ship it! Ship It! - Zameer Manji On Jan. 29, 2015, 12:11 p.m

  1   2   3   4   5   >