Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48949 --- Ship it! Ship It! - Kevin Sweeney On July 26, 2014, 11:16 a.m.,

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-28 Thread Bill Farner
> On July 28, 2014, 9:16 p.m., Kevin Sweeney wrote: > > build.gradle, line 232 > > > > > > Is there an actual dependency conflict here? Yes. com.twitter.common.net-http-handlers pulls in 2.2.2. - Bill ---

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48905 --- build.gradle

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48897 --- All ship-its have been given, but i'll give you guys until EOD to ve

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/ --- (Updated July 26, 2014, 6:16 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/ --- (Updated July 26, 2014, 3:43 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-25 Thread Bill Farner
> On July 23, 2014, 2:47 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java, lines > > 111-117 > > > > > > Since metadata is extracted using method name, would it make s

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-25 Thread Bill Farner
> On July 22, 2014, 11:20 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java, line 170 > > > > > > Should this location be hardcoded like this or can it be injected? > > Rig

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/ --- (Updated July 25, 2014, 6:07 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48327 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/api/ApiBet

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48450 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/api/ApiBet

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48449 --- Ship it! lgtm. - David McLaughlin On July 21, 2014, 4:59 p.m.,

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread David McLaughlin
> On July 22, 2014, 10:52 p.m., David McLaughlin wrote: > > Overall I think this is great. For my own curiosity - any reason why you've > > used gson over the simple JSON protocol that comes with Thrift? > > Bill Farner wrote: > TSimpleJSONProtocol is one-way, so it doesn't solve consumptio

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread Bill Farner
> On July 22, 2014, 10:52 p.m., David McLaughlin wrote: > > Overall I think this is great. For my own curiosity - any reason why you've > > used gson over the simple JSON protocol that comes with Thrift? TSimpleJSONProtocol is one-way, so it doesn't solve consumption of parameters. I original

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48442 --- Overall I think this is great. For my own curiosity - any reason why

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/ --- (Updated July 21, 2014, 4:59 p.m.) Review request for Aurora, Kevin Sweeney and