Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63700 --- Ship it! Master (8959b49) is green with this patch. ./build-suppo

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/ --- (Updated Dec. 3, 2014, 6:23 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Bill Farner
> On Dec. 3, 2014, 2:06 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, > > line 56 > > > > > > This can be further simplified (unless you are conce

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63637 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/preemptor

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63635 --- Ship it! Ship It! - Zameer Manji On Dec. 2, 2014, 5:39 p.m., Bil

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63632 --- Ship it! Master (552ae93) is green with this patch. ./build-suppo

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/ --- (Updated Dec. 3, 2014, 1:39 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
> On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, > > line 58 > > > > > > Would it make sense to do it conditionally, i.e.: >

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
> On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, > > line 58 > > > > > > Would it make sense to do it conditionally, i.e.: >

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
> On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, > > line 52 > > > > > > minor nit: you might want to have it outside the sy

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63598 --- src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClu

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63596 --- Ship it! Master (c86ca6d) is green with this patch. ./build-suppo