Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- (Updated March 14, 2014, 11:24 p.m.) Review request for Aurora, Kevin Sweeney a

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-14 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/#review37275 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 10:29 a.m.,

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-11 Thread Bill Farner
> On March 5, 2014, 6:18 p.m., Bill Farner wrote: > > Ping? Kevin — waiting on a review from you. Ping? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/#review36247

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/#review36247 --- Ping? Kevin — waiting on a review from you. - Bill Farner On Mar

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- (Updated March 3, 2014, 6:29 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-03 Thread Bill Farner
> On Feb. 26, 2014, 7:30 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line > > 335 > > > > > > How about extracting a private transactionManager field initi

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-02-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/#review35547 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/log/Log

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-02-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- (Updated Feb. 26, 2014, 12:12 a.m.) Review request for Aurora, Kevin Sweeney an

Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-02-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur