Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-21 Thread Mark Chu-Carroll
On May 20, 2014, 10:58 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java, line 135 https://reviews.apache.org/r/21383/diff/4-5/?file=584804#file584804line135 remove trailing WS. this should be trivial to catch in

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- (Updated May 21, 2014, 9:05 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-21 Thread Bill Farner
On May 21, 2014, 2:58 a.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java, line 135 https://reviews.apache.org/r/21383/diff/4-5/?file=584804#file584804line135 remove trailing WS. this should be trivial to catch in

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/#review43535 --- Ship it! lgtm. - David McLaughlin On May 20, 2014, 12:25 a.m.,

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- (Updated May 20, 2014, 6:56 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-20 Thread Bill Farner
On May 21, 2014, 2:58 a.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java, line 135 https://reviews.apache.org/r/21383/diff/4-5/?file=584804#file584804line135 remove trailing WS. this should be trivial to catch in

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- (Updated May 19, 2014, 11:25 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/#review43388 ---

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/#review43397 ---

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-19 Thread Bill Farner
On May 19, 2014, 9:11 p.m., Mark Chu-Carroll wrote: src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java, line 147 https://reviews.apache.org/r/21383/diff/3/?file=584300#file584300line147 Just to be clear: there is no deprecation here. The existing behavior

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-19 Thread Mark Chu-Carroll
On May 19, 2014, 5:11 p.m., Mark Chu-Carroll wrote: src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java, line 147 https://reviews.apache.org/r/21383/diff/3/?file=584300#file584300line147 Just to be clear: there is no deprecation here. The existing behavior

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-19 Thread Maxim Khutornenko
On May 19, 2014, 9:11 p.m., Mark Chu-Carroll wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 258 https://reviews.apache.org/r/21383/diff/3/?file=584301#file584301line258 There are tests of scheduleCronJob and descheduleCronJob below.

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-19 Thread Bill Farner
On May 19, 2014, 9:11 p.m., Mark Chu-Carroll wrote: src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java, line 147 https://reviews.apache.org/r/21383/diff/3/?file=584300#file584300line147 Just to be clear: there is no deprecation here. The existing behavior

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- (Updated May 19, 2014, 8:25 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/#review43012 --- Heads up: this has high likelihood of conflicting with

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-14 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- (Updated May 14, 2014, 10:39 a.m.) Review request for Aurora, David McLaughlin

Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-13 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: aurora-417